]> granicus.if.org Git - clang/commitdiff
Set up vtable visibility appropriately.
authorMike Stump <mrs@apple.com>
Wed, 18 Nov 2009 04:00:48 +0000 (04:00 +0000)
committerMike Stump <mrs@apple.com>
Wed, 18 Nov 2009 04:00:48 +0000 (04:00 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@89193 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CGVtable.cpp

index efca4f2fbe881bd266660a811195b710771f0585..4c97a9bdeebfbbd19e465dda319353e05b1b1357 100644 (file)
@@ -813,10 +813,13 @@ llvm::Constant *CodeGenModule::GenerateVtable(const CXXRecordDecl *LayoutClass,
   llvm::Constant *C;
   llvm::ArrayType *type = llvm::ArrayType::get(Ptr8Ty, methods.size());
   C = llvm::ConstantArray::get(type, methods);
-  llvm::Constant *vtable = new llvm::GlobalVariable(getModule(), type,
-                                                    true, linktype, C,
-                                                    Out.str());
-  vtable = llvm::ConstantExpr::getBitCast(vtable, Ptr8Ty);
+  llvm::GlobalVariable *GV = new llvm::GlobalVariable(getModule(), type,
+                                                      true, linktype, C,
+                                                      Out.str());
+  bool Hidden = getDeclVisibilityMode(RD) == LangOptions::Hidden;
+  if (Hidden)
+    GV->setVisibility(llvm::GlobalVariable::HiddenVisibility);
+  llvm::Constant *vtable = llvm::ConstantExpr::getBitCast(GV, Ptr8Ty);
   llvm::Constant *AddressPointC;
   uint32_t LLVMPointerWidth = getContext().Target.getPointerWidth(0);
   AddressPointC = llvm::ConstantInt::get(llvm::Type::getInt64Ty(VMContext),
@@ -1011,10 +1014,12 @@ llvm::Constant *CodeGenModule::GenerateVTT(const CXXRecordDecl *RD) {
   llvm::Constant *C;
   llvm::ArrayType *type = llvm::ArrayType::get(Ptr8Ty, inits.size());
   C = llvm::ConstantArray::get(type, inits);
-  llvm::Constant *vtt = new llvm::GlobalVariable(getModule(), type, true,
+  llvm::GlobalVariable *vtt = new llvm::GlobalVariable(getModule(), type, true,
                                                  linktype, C, Out.str());
-  vtt = llvm::ConstantExpr::getBitCast(vtt, Ptr8Ty);
-  return vtt;
+  bool Hidden = getDeclVisibilityMode(RD) == LangOptions::Hidden;
+  if (Hidden)
+    vtt->setVisibility(llvm::GlobalVariable::HiddenVisibility);
+  return llvm::ConstantExpr::getBitCast(vtt, Ptr8Ty);
 }
 
 llvm::Constant *CGVtableInfo::getVtable(const CXXRecordDecl *RD) {