]> granicus.if.org Git - apache/commitdiff
Axe a useless comment.
authorChristophe Jaillet <jailletc36@apache.org>
Sat, 20 Apr 2019 07:01:29 +0000 (07:01 +0000)
committerChristophe Jaillet <jailletc36@apache.org>
Sat, 20 Apr 2019 07:01:29 +0000 (07:01 +0000)
Remove some dead code and innacurate comment. 'r' can not be dereferenced later in the function. (this is obvious since r1814659)

(Reverted in r1858070)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1857857 13f79535-47bb-0310-9956-ffa450edef68

modules/http/http_core.c

index 746cf704a7bc29d519f3c7fe896b9d9a713df3b9..a241783673fdf3be69d803dc94e3f4e3ff9438ba 100644 (file)
@@ -57,7 +57,6 @@ static const char *set_keep_alive_timeout(cmd_parms *cmd, void *dummy,
         return err;
     }
 
-    /* Stolen from mod_proxy.c */
     if (ap_timeout_parameter_parse(arg, &timeout, "s") != APR_SUCCESS)
         return "KeepAliveTimeout has wrong format";
     cmd->server->keep_alive_timeout = timeout;
@@ -156,14 +155,6 @@ static int ap_process_http_async_connection(conn_rec *c)
                 }
                 ap_update_child_status(c->sbh, SERVER_BUSY_WRITE, r);
                 ap_process_async_request(r);
-                /* After the call to ap_process_request, the
-                 * request pool may have been deleted.  We set
-                 * r=NULL here to ensure that any dereference
-                 * of r that might be added later in this function
-                 * will result in a segfault immediately instead
-                 * of nondeterministic failures later.
-                 */
-                r = NULL;
             }
 
             if (cs->state != CONN_STATE_WRITE_COMPLETION &&