Free buffer in php_verror even if it is empty

vspprintf allocates a buffer even if the resulting string is empty.

diff --git a/main/main.c b/main/main.c
index 7890b2ebeb12fff0e9c7fb6ddc456d7baf62a463..e1491db1fd18f1a0e0fbd8a046422eb30d6d823f 100644 (file)
--- a/main/main.c
+++ b/main/main.c
@@ -1132,9 +1132,7 @@ PHPAPI ZEND_COLD void php_verror(const char *docref, const char *params, int typ
        if (replace_buffer) {
                zend_string_free(replace_buffer);
        } else {
-               if (buffer_len > 0) {
-                       efree(buffer);
-               }
+               efree(buffer);
        }
 
        php_error(type, "%s", message);