]> granicus.if.org Git - clang/commitdiff
[ClangDiagnostics] Silence warning about fallthrough after PrintFatalError
authorDavid Bolvansky <david.bolvansky@gmail.com>
Sat, 26 May 2018 09:24:00 +0000 (09:24 +0000)
committerDavid Bolvansky <david.bolvansky@gmail.com>
Sat, 26 May 2018 09:24:00 +0000 (09:24 +0000)
Summary:
ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through [-Wimplicit-fallthrough=]
       Builder.PrintFatalError("Unknown modifier type: " + Modifier);
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
ClangDiagnosticsEmitter.cpp:1048:5: note: here
     case MT_Select: {
                   ^

Reviewers: rsmith, rtrieu

Reviewed By: rtrieu

Subscribers: rtrieu, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits

Differential Revision: https://reviews.llvm.org/D47340

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@333340 91177308-0d34-0410-b5e6-96231b3b80d8

utils/TableGen/ClangDiagnosticsEmitter.cpp

index fd9efd35582db2709eceb01ca84631939977cfeb..6bfb3f9f61f542be94fdee4164d100b87afdfb9c 100644 (file)
@@ -633,7 +633,7 @@ struct DiagnosticTextBuilder {
     return It->second.Root;
   }
 
-  void PrintFatalError(llvm::Twine const &Msg) const {
+  LLVM_ATTRIBUTE_NORETURN void PrintFatalError(llvm::Twine const &Msg) const {
     assert(EvaluatingRecord && "not evaluating a record?");
     llvm::PrintFatalError(EvaluatingRecord->getLoc(), Msg);
   }