patch 7.4.1831

Problem:    When timer_stop() is called with a string there is no proper error
            message.
Solution:   Require getting a number. (Bjorn Linse)

diff --git a/src/eval.c b/src/eval.c
index 83bac7243907c8d25a497b876d1fb46a82396146..005485dd9c6e3b31878c14d93e4526c50e498aeb 100644 (file)
--- a/src/eval.c
+++ b/src/eval.c
@@ -20733,8 +20733,14 @@ f_timer_start(typval_T *argvars, typval_T *rettv)
     static void
 f_timer_stop(typval_T *argvars, typval_T *rettv UNUSED)
 {
-    timer_T *timer = find_timer(get_tv_number(&argvars[0]));
+    timer_T *timer;
 
+    if (argvars[0].v_type != VAR_NUMBER)
+    {
+         EMSG(_(e_number_exp));
+         return;
+    }
+    timer = find_timer(get_tv_number(&argvars[0]));
     if (timer != NULL)
        stop_timer(timer);
 }

diff --git a/src/version.c b/src/version.c
index caf1e46ff76909c4bc3d9125a86b2fa94389ba37..e1297c819a805de86fe2d541a8802d72f062853a 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -753,6 +753,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1831,
 /**/
     1830,
 /**/