]> granicus.if.org Git - procps-ng/commitdiff
tests: slabinfo should not be too strict about slab names
authordmarc-noreply@freelists.org <dmarc-noreply@freelists.org>
Wed, 6 May 2015 22:17:24 +0000 (15:17 -0700)
committerCraig Small <csmall@enc.com.au>
Sun, 10 May 2015 05:05:28 +0000 (15:05 +1000)
Before this commit, the test checking `vmstat -m` (slabinfo) output uses
a fairly strict regular expression that only allows alphanumeric
characters and a few exceptions such as "_", "-", "(" and ")".

However, recent kernels use a wider range of characters, such as ">".
For instance, see this Linux commit which creates a "page->ptl" slab:
  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/mm/memory.c?id=b35f1819acd9243a3ff7ad25b1fa8bd6bfe80fb2#n4283

Other patches for reporting slab usage per memcg include the names of
the cgroup in the slabinfo output, which can include additional
characters and use dots for abbreviation.

The check should not be so string, instead it could simply look for a
chain of non-whitespace characters and that should be enough.

Tested that `make check` is still working, including in some of the
environments where features that enable the additional slabinfo names.

Signed-off-by: Filipe Brandenburger <filbranden@google.com>
Signed-off-by: Craig Small <csmall@enc.com.au>
testsuite/vmstat.test/vmstat.exp

index 35ffddb8e5c87a220caadb8db0678d753e67c38f..0bc00b4d1dbae6d29fd1e94e4e2126ffe283359d 100644 (file)
@@ -22,7 +22,7 @@ if { [ file readable "/proc/slabinfo" ] == 0 } {
 } else {
 set test "vmstat slabinfo (-m option)"
 spawn $vmstat -m
-expect_pass "$test" "^Cache\\s+Num\\s+Total\\s+Size\\s+Pages\\s+\(\[\(\)A-Za-z0-9_-\]+\\s+\\d+\\s+\\d+\\s+\\d+\\s+\\d+\\s*\){1,}"
+expect_pass "$test" "^Cache\\s+Num\\s+Total\\s+Size\\s+Pages\\s+\(\\S+\\s+\\d+\\s+\\d+\\s+\\d+\\s+\\d+\\s*\){1,}"
 }
 
 set test "vmstat disk information (-d option)"