Fix bug leading to restoring unlogged relations from empty files.

At the end of crash recovery, unlogged relations are reset to the empty
state, using their init fork as the template. The init fork is copied to
the main fork without going through shared buffers. Unfortunately WAL
replay so far has not necessarily flushed writes from shared buffers to
disk at that point. In normal crash recovery, and before the
introduction of 'fast promotions' in fd4ced523 / 9.3, the
END_OF_RECOVERY checkpoint flushes the buffers out in time. But with
fast promotions that's not the case anymore.

To fix, force WAL writes targeting the init fork to be flushed
immediately (using the new FlushOneBuffer() function). In 9.5+ that
flush can centrally be triggered from the code dealing with restoring
full page writes (XLogReadBufferForRedoExtended), in earlier releases
that responsibility is in the hands of XLOG_HEAP_NEWPAGE's replay
function.

Backpatch to 9.1, even if this currently is only known to trigger in
9.3+. Flushing earlier is more robust, and it is advantageous to keep
the branches similar.

Typical symptoms of this bug are errors like
'ERROR:  index "..." contains unexpected zero page at block 0'
shortly after promoting a node.

Reported-By: Thom Brown
Author: Andres Freund and Michael Paquier
Discussion: 20150326175024.GJ451@alap3.anarazel.de
Backpatch: 9.1-

diff --git a/src/backend/access/transam/xlogutils.c b/src/backend/access/transam/xlogutils.c
index a5003c3b92277ff59a4174bce2fa67c132bfbb89..9073a850e8b1c114d79f3cbc1dc8717607b98a35 100644 (file)
--- a/src/backend/access/transam/xlogutils.c
+++ b/src/backend/access/transam/xlogutils.c
@@ -368,6 +368,15 @@ XLogReadBufferForRedoExtended(XLogReaderState *record,
 
                MarkBufferDirty(*buf);
 
+               /*
+                * At the end of crash recovery the init forks of unlogged relations
+                * are copied, without going through shared buffers. So we need to
+                * force the on-disk state of init forks to always be in sync with the
+                * state in shared buffers.
+                */
+               if (forknum == INIT_FORKNUM)
+                       FlushOneBuffer(*buf);
+
                return BLK_RESTORED;
        }
        else

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 63188a3932ecc4e364c3dc7471b508c5b15cb8c3..b32543b1d56d79a3d92440e5a3156b07cca0586d 100644 (file)
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -2988,6 +2988,27 @@ FlushDatabaseBuffers(Oid dbid)
        }
 }
 
+/*
+ * Flush a previously, shared or exclusively, locked and pinned buffer to the
+ * OS.
+ */
+void
+FlushOneBuffer(Buffer buffer)
+{
+       BufferDesc *bufHdr;
+
+       /* currently not needed, but no fundamental reason not to support */
+       Assert(!BufferIsLocal(buffer));
+
+       Assert(BufferIsPinned(buffer));
+
+       bufHdr = GetBufferDescriptor(buffer - 1);
+
+       LWLockHeldByMe(bufHdr->content_lock);
+
+       FlushBuffer(bufHdr, NULL);
+}
+
 /*
  * ReleaseBuffer -- release the pin on a buffer
  */

diff --git a/src/include/storage/bufmgr.h b/src/include/storage/bufmgr.h
index 0f59201bf5bed800f49d28c5086ba567894628bd..09b2b1170fac30cb42583f9ac05d46bdb4e93a6b 100644 (file)
--- a/src/include/storage/bufmgr.h
+++ b/src/include/storage/bufmgr.h
@@ -176,6 +176,7 @@ extern void CheckPointBuffers(int flags);
 extern BlockNumber BufferGetBlockNumber(Buffer buffer);
 extern BlockNumber RelationGetNumberOfBlocksInFork(Relation relation,
                                                                ForkNumber forkNum);
+extern void FlushOneBuffer(Buffer buffer);
 extern void FlushRelationBuffers(Relation rel);
 extern void FlushDatabaseBuffers(Oid dbid);
 extern void DropRelFileNodeBuffers(RelFileNodeBackend rnode,