Fix memory leak in handling of request bodies during reverse

proxy operations.

PR:      24991
Submitted by: Larry Toppi <larry.toppi citrix.com>
Reviewed by:  Jeff Trawick

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102017 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index 9dfd34e8c4e45321cfb8ab7d3a0c309450eadc05..164d7183ffa980dd036e4730c68fad24059f1644 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,9 @@ Changes with Apache 2.1.0-dev
 
   [Remove entries to the current 2.0 section below, when backported]
 
+  *) Fix memory leak in handling of request bodies during reverse
+     proxy operations.  PR 24991. [Larry Toppi <larry.toppi citrix.com>]
+
   *) Clean up httpd -V output: Instead of displaying the MPM source
      directory, display the MPM name and some MPM properties.
      [Geoffrey Young <geoff apache.org>]

diff --git a/modules/proxy/proxy_http.c b/modules/proxy/proxy_http.c
index 355094055db26c169dce53625ea79c5669c37978..aab0661390cda51fe59d3c11c9c35f2a0b2dd201 100644 (file)
--- a/modules/proxy/proxy_http.c
+++ b/modules/proxy/proxy_http.c
@@ -687,7 +687,8 @@ apr_status_t ap_proxy_http_request(apr_pool_t *p, request_rec *r,
             }
 
             /* We can't pass this EOS to the output_filters. */
-            APR_BUCKET_REMOVE(APR_BRIGADE_LAST(input_brigade));
+            e = APR_BRIGADE_LAST(input_brigade);
+            apr_bucket_delete(e);
         }
 
         if (send_chunks) {