]> granicus.if.org Git - php/commitdiff
- Check another incarnation of bug #30266
authorMarcus Boerger <helly@php.net>
Sat, 19 Mar 2005 14:24:17 +0000 (14:24 +0000)
committerMarcus Boerger <helly@php.net>
Sat, 19 Mar 2005 14:24:17 +0000 (14:24 +0000)
ext/standard/array.c
ext/standard/tests/array/bug30266.phpt [new file with mode: 0755]

index 894f99a426779f8254a137e260490b4212b35444..1175b3303a9652e5f133439010082751c6957fc2 100644 (file)
@@ -1038,7 +1038,7 @@ static int php_array_walk(HashTable *target_hash, zval **userdata, int recursive
        zend_hash_internal_pointer_reset_ex(target_hash, &pos);
 
        /* Iterate through hash */
-       while (zend_hash_get_current_data_ex(target_hash, (void **)&args[0], &pos) == SUCCESS) {
+       while (!EG(exception) && zend_hash_get_current_data_ex(target_hash, (void **)&args[0], &pos) == SUCCESS) {
                if (recursive && Z_TYPE_PP(args[0]) == IS_ARRAY) {
                        HashTable *thash;
                        
diff --git a/ext/standard/tests/array/bug30266.phpt b/ext/standard/tests/array/bug30266.phpt
new file mode 100755 (executable)
index 0000000..8f7c3d2
--- /dev/null
@@ -0,0 +1,37 @@
+--TEST--
+Bug #30266 (Invalid opcode 137/1/8) and array_walk
+--FILE--
+<?php
+class testc
+{
+       public $b = "c";
+
+       function crash($val)
+       {
+               $this->b = $val;
+               throw new Exception("Error");
+       }
+}
+
+$fruits = array ("d"=>"lemon", "a"=>"orange", "b"=>"banana", "c"=>"apple");
+
+$myobj = new testc();
+
+function test($item2, $key, $userd)
+{
+       $userd->crash($item2);
+}
+
+try
+{
+       array_walk($fruits, 'test', $myobj);
+}
+catch(Exception $e)
+{
+       echo "Caught: " . $e->getMessage() . "\n";
+}
+?>
+===DONE===
+--EXPECT--
+Caught: Error
+===DONE===