Fix Hot Standby feedback sending when streaming busily.

Commit 6f60fdd7015b032bf49273c99f80913d57eac284 accidentally removed a
call to XLogWalRcvSendHSFeedback() after flushing received WAL to disk.
The consequence is that when walsender is busy streaming WAL, it doesn't
send HS feedback messages. One is sent if nothing is received from the
master for 100ms, but if there's a steady stream of WAL, it never happens.

Backpatch to 9.3.

Andres Freund and Amit Kapila

diff --git a/src/backend/replication/walreceiver.c b/src/backend/replication/walreceiver.c
index 413f0b94051d083475ef4cc22098b0b2a8808065..7fe80a94a3075d66a8b7334468391209a6210d20 100644 (file)
--- a/src/backend/replication/walreceiver.c
+++ b/src/backend/replication/walreceiver.c
@@ -1007,7 +1007,10 @@ XLogWalRcvFlush(bool dying)
 
                /* Also let the master know that we made some progress */
                if (!dying)
+               {
                        XLogWalRcvSendReply(false, false);
+                       XLogWalRcvSendHSFeedback(false);
+               }
        }
 }