]> granicus.if.org Git - php/commitdiff
Fixed bug #48469 (ldap_get_entries() memory leaks on empty search results)
authorPatrick Allaert <patrickallaert@php.net>
Sun, 7 Jun 2009 13:06:03 +0000 (13:06 +0000)
committerPatrick Allaert <patrickallaert@php.net>
Sun, 7 Jun 2009 13:06:03 +0000 (13:06 +0000)
ext/ldap/ldap.c

index 12b7c23888d8d9192d5360a3385b6177911877a2..db10408176cc29831849bc2a0358e1018ff381e2 100644 (file)
@@ -19,6 +19,7 @@
    |          Jani Taskinen  <sniper@iki.fi>                              |
    |          Stig Venaas    <venaas@uninett.no>                          |
    |          Doug Goldstein <cardoe@cardoe.com>                          |
+   |          Patrick Allaert <patrickallaert@php.net>                    |
    | PHP 4.0 updates:  Zeev Suraski <zeev@zend.com>                       |
    +----------------------------------------------------------------------+
  */
@@ -972,9 +973,6 @@ PHP_FUNCTION(ldap_get_entries)
        ldap = ld->link;
        num_entries = ldap_count_entries(ldap, ldap_result);
 
-       array_init(return_value);
-       add_assoc_long(return_value, "count", num_entries);
-
        if (num_entries == 0) {
                RETURN_NULL();
        }
@@ -985,6 +983,9 @@ PHP_FUNCTION(ldap_get_entries)
                RETURN_FALSE;
        }
 
+       array_init(return_value);
+       add_assoc_long(return_value, "count", num_entries);
+
        while (ldap_result_entry != NULL) {
 
                MAKE_STD_ZVAL(tmp1);