- Based on bug report #2723219 (http://curl.haxx.se/bug/view.cgi?id=2723219)

  I've now made TFTP "connections" not being kept for re-use within libcurl.
  TFTP is UDP-based so the benefit was really low (if even existing) to begin
  with so instead of tracking down to fix this problem we instead removed the
  re-use. I also enabled test case 1099 that I wrote a few days ago to verify
  that this change fixes the reported problem.

diff --git a/CHANGES b/CHANGES
index 605c8def444e168317e0b95837bf08002ba2814d..2cdeaef6a60845fc0e0fc909ae899c4f89c54a0d 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,14 @@
 
                                   Changelog
 
+Daniel Stenberg (29 Apr 2009)
+- Based on bug report #2723219 (http://curl.haxx.se/bug/view.cgi?id=2723219)
+  I've now made TFTP "connections" not being kept for re-use within libcurl.
+  TFTP is UDP-based so the benefit was really low (if even existing) to begin
+  with so instead of tracking down to fix this problem we instead removed the
+  re-use. I also enabled test case 1099 that I wrote a few days ago to verify
+  that this change fixes the reported problem.
+
 Daniel Stenberg (28 Apr 2009)
 - Constantine Sapuntzakis filed bug report #2783090
   (http://curl.haxx.se/bug/view.cgi?id=2783090) pointing out that on windows

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 93b4855bdcd70e6afd75b8e9d13ad4c054a23862..c2b65e76e2cc623657fd4581e398fa8853e87f19 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -35,6 +35,7 @@ This release includes the following bugfixes:
  o crash related to FTP and "Re-used connection seems dead, get a new one"
  o CURLINFO_APPCONNECT_TIME with the multi interface
  o Enhanced upload speeds on Windows
+ o TFTP problems after a failed transfer to the same host
 
 This release includes the following known bugs:
 

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 726287d572898c97184ed876c56cf015f337b1c9..0e1ad481017f50cfb617c3be8ae7c36692a16939 100644 (file)
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -3,8 +3,6 @@ To be addressed in 7.19.5 (planned release: May 2009)
 
 221 - debian man page warnings
 
-222 - TFTP close bug/fix, #2723219
-
 223 - TFTP flaw, #2723236
 
 226 - Active Mode FTPS Data Port Range

diff --git a/lib/tftp.c b/lib/tftp.c
index 509c2ccaee9fac4f7fe6b01be5ed3b3a638878c4..6440f80258ff9099950ce06636589311b05a12b8 100644 (file)
--- a/lib/tftp.c
+++ b/lib/tftp.c
@@ -863,7 +863,9 @@ static CURLcode tftp_connect(struct connectdata *conn, bool *done)
       return CURLE_OUT_OF_MEMORY;
   }
 
-  conn->bits.close = FALSE; /* keep it open if possible */
+  conn->bits.close = TRUE; /* we don't keep TFTP connections up bascially
+                              because there's none or very little gain for UDP
+                           */
 
   state->conn = conn;
   state->sockfd = state->conn->sock[FIRSTSOCKET];

diff --git a/tests/data/DISABLED b/tests/data/DISABLED
index 16af58335c2fbcdbbabfd3511fb8bb931c79a8a6..fb3ae0ec927f147df75ce201deea81825a1fde3b 100644 (file)
--- a/tests/data/DISABLED
+++ b/tests/data/DISABLED
@@ -3,4 +3,4 @@
 # test cases are run by runtests.pl. Just add the plain test case numbers, one
 # per line.
 # Lines starting with '#' letters are treated as comments.
-1099
+

diff --git a/tests/data/test1099 b/tests/data/test1099
index 5c80ac5d0ae75e27426100c2fc4c7fc6ed38bdab..f81e6017b08a2800fb02152c2bc545e1955a4961 100644 (file)
--- a/tests/data/test1099
+++ b/tests/data/test1099
@@ -8,7 +8,7 @@ FAILURE
 </info>
 
 <reply>
-<data>
+<data nocheck="yes">
 data for 1099
 </data>
 </reply>
@@ -30,9 +30,6 @@ tftp://%HOSTIP:%TFTPPORT/an/invalid-file tftp://%HOSTIP:%TFTPPORT//1099 --trace-
 #
 # Verify pseudo protocol after the test has been "shot"
 <verify>
-<errorcode>
-69
-</errorcode>
 <protocol>
 opcode: 1
 filename: an/invalid-file
@@ -41,5 +38,8 @@ opcode: 1
 filename: /1099
 mode: octet
 </protocol>
+<stdout mode="text">
+data for 1099
+</stdout>
 </verify>
 </testcase>