remove comparisons against 'TRUE' literal

The variables involved here are all booleans or used exclusively as booleans.

diff --git a/cmd/lefty/aix_mods/exec.c b/cmd/lefty/aix_mods/exec.c
index c501c032de70d59ddfee5bd2de492d2b6d2daf45..8e81a5c3f8f7c802725481a33334eb0c5c94e07d 100644 (file)
--- a/cmd/lefty/aix_mods/exec.c
+++ b/cmd/lefty/aix_mods/exec.c
@@ -277,7 +277,7 @@ static Tobj eeval(Tobj co, int ci)
            err(ERRNORHS, ERR4, co, TCgetnext(co, i1));
        if (v1o)
            Mpopmark(m1);
-       return (orderop(v1o, ctype, v2o) == TRUE) ? Ttrue : Tfalse;
+       return orderop(v1o, ctype, v2o) ? Ttrue : Tfalse;
     case C_PLUS:
     case C_MINUS:
     case C_MUL:

diff --git a/cmd/lefty/exec.c b/cmd/lefty/exec.c
index 36f7dc745641e0f88e2e395ef2a1fd4686711e7d..f3a79feac6fa7d22a8db601e064e6cba4c456350 100644 (file)
--- a/cmd/lefty/exec.c
+++ b/cmd/lefty/exec.c
@@ -286,7 +286,7 @@ tailrec:
             err (ERRNORHS, ERR4, co, TCgetnext (co, i1));
         if (v1o)
             Mpopmark (m1);
-        return (orderop (v1o, ctype, v2o) == TRUE) ? Ttrue: Tfalse;
+        return orderop (v1o, ctype, v2o) ? Ttrue: Tfalse;
     case C_PLUS:
     case C_MINUS:
     case C_MUL:

diff --git a/cmd/lefty/leftyio.h b/cmd/lefty/leftyio.h
index 7fd42d6654523676712becc4b2530e00f0f3544b..2849fb03de83d621a1e71834e83790cfb387b2ba 100644 (file)
--- a/cmd/lefty/leftyio.h
+++ b/cmd/lefty/leftyio.h
@@ -49,7 +49,7 @@ typedef struct io_t {
 } while (0)
 #endif
 
-#define IOismonitored(ioi) (iop[ioi].ismonitored == TRUE)
+#define IOismonitored(ioi) iop[ioi].ismonitored
 #define IOINCR 5
 #define IOSIZE sizeof (io_t)
 #define IOBUFSIZE 2048

diff --git a/cmd/smyrna/gltemplate.c b/cmd/smyrna/gltemplate.c
index 59ed9af88819a025d6357bd7865ad1242b1787ca..a7fa339dc445e44d2f6691f82868639cd0c33e29 100644 (file)
--- a/cmd/smyrna/gltemplate.c
+++ b/cmd/smyrna/gltemplate.c
@@ -58,7 +58,7 @@ static void print_gl_config_attrib(GdkGLConfig * glconfig,
     g_print("%s = ", attrib_str);
     if (gdk_gl_config_get_attrib(glconfig, attrib, &value)) {
        if (is_boolean)
-           g_print("%s\n", value == TRUE ? "TRUE" : "FALSE");
+           g_print("%s\n", value ? "TRUE" : "FALSE");
        else
            g_print("%d\n", value);
     } else

diff --git a/lib/dotgen/mincross.c b/lib/dotgen/mincross.c
index 6b868cf38eff96bca7fe570448a365e7c722bf63..43e3d4c6d4560e4ecf6243fbcd1af6dde8a160aa 100644 (file)
--- a/lib/dotgen/mincross.c
+++ b/lib/dotgen/mincross.c
@@ -1222,7 +1222,7 @@ static void flat_search(graph_t * g, node_t * v)
                continue;
            if (ED_weight(e) == 0)
                continue;
-           if (ND_onstack(aghead(e)) == TRUE) {
+           if (ND_onstack(aghead(e))) {
                assert(flatindex(aghead(e)) < M->nrows);
                assert(flatindex(agtail(e)) < M->ncols);
                ELT(M, flatindex(aghead(e)), flatindex(agtail(e))) = 1;