]> granicus.if.org Git - clang/commitdiff
Driver: I was too hasty in free'ing Actions, we sometimes share
authorDaniel Dunbar <daniel@zuster.org>
Wed, 18 Mar 2009 03:02:22 +0000 (03:02 +0000)
committerDaniel Dunbar <daniel@zuster.org>
Wed, 18 Mar 2009 03:02:22 +0000 (03:02 +0000)
Actions so a simple tree traversal isn't quite good enough. Leaving a
FIXME for now.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@67161 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/Action.cpp

index 71bf22ffa12d35512dc8097b77b38491769e2c01..cabc33eaec28808939f6ca4aa3b2e8f16dbcfe73 100644 (file)
@@ -13,9 +13,8 @@
 using namespace clang::driver;
 
 Action::~Action() {
-  // Free the inputs.
-  for (iterator it = begin(), ie = end(); it != ie; ++it)
-    delete *it;  
+  // FIXME: Free the inputs. The problem is that BindArchAction shares
+  // inputs; so we can't just walk the inputs.
 }
 
 const char *Action::getClassName(ActionClass AC) {