Add support for systems with no innetgr(). On those systems, username

with an @ will be treated like any other username (i.e. lookup in the
local database for an user with an @). Thanks to Mike Frysinger for the
patch.

diff --git a/ChangeLog b/ChangeLog
index bdf36de5bbed1ab8fcbea2751827fb493256c7fd..d03b2656844da44e6f965cb1750a85950b493dd5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2007-11-16  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * configure.in: Check if the netdb.h header file and the innetgr
+       function exist.
+       * src/login_nopam.c, NEWS: Add support for systems with no
+       innetgr().  On those systems, username with an @ will be treated
+       like any other username (i.e. lookup in the local database for an
+       user with an @). Thanks to Mike Frysinger for the patch.
+
 2007-11-16  Nicolas François  <nicolas.francois@centraliens.net>
 
        * src/useradd.c: Indentation fix.

diff --git a/NEWS b/NEWS
index dc2952dbc755262fb52284ac5157a3c27f73f30b..9135a7ea5b52c949e944f60cc415fda6a062ce46 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -15,6 +15,10 @@ shadow-4.0.18.1 -> shadow-4.0.18.2                                   UNRELEASED
 - newgrp.c: Declare the child and pid variable at the beginning of a block.
   This fixes a compilation issue with gcc 2.95. The intent is the same as
   Gentoo's patch shadow-4.0.12-gcc2.patch.
+- login_nopam: Add support for systems with no innetgr().  On those
+  systems, username with an @ will be treated like any other username
+  (i.e. lookup in the local database for an user with an @). Thanks to
+  Mike Frysinger for the patch.
 
 shadow-4.0.18.1 -> shadow-4.0.18.2                                     28-10-2007
 

diff --git a/configure.in b/configure.in
index 67198494e56e3529024f508df955c0f5b3320999..d7546e5a17a4fe601877f282c528f031361cd081 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -32,11 +32,11 @@ AC_HEADER_SYS_WAIT
 AC_CHECK_HEADERS(errno.h fcntl.h limits.h unistd.h sys/time.h utmp.h \
        utmpx.h termios.h termio.h sgtty.h sys/ioctl.h syslog.h paths.h \
        utime.h ulimit.h sys/resource.h gshadow.h shadow.h lastlog.h \
-       locale.h rpc/key_prot.h)
+       locale.h rpc/key_prot.h netdb.h)
 
 AC_CHECK_FUNCS(a64l fchmod fchown fsync getgroups gethostname getspnam \
        gettimeofday getusershell getutent initgroups lchown lckpwdf lstat \
-       memcpy memset setgroups sigaction strchr updwtmp updwtmpx)
+       memcpy memset setgroups sigaction strchr updwtmp updwtmpx innetgr)
 AC_SYS_LARGEFILE
 
 dnl Checks for typedefs, structures, and compiler characteristics.

diff --git a/src/login_nopam.c b/src/login_nopam.c
index 16319545e44ef68720a1ad4ff4a0b8c6b4640bcb..6f784bee12b32f67463621c46648c99a73a0e609 100644 (file)
--- a/src/login_nopam.c
+++ b/src/login_nopam.c
@@ -37,7 +37,9 @@
 #include <stdio.h>
 #include <syslog.h>
 #include <ctype.h>
+#ifdef HAVE_NETDB_H
 #include <netdb.h>
+#endif
 #include <grp.h>
 #ifdef PRIMARY_GROUP_MATCH
 #include <pwd.h>
@@ -49,8 +51,6 @@
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>         /* for inet_ntoa() */
-extern struct group *getgrnam ();
-extern int innetgr ();
 
 #if !defined(MAXHOSTNAMELEN) || (MAXHOSTNAMELEN < 64)
 #undef MAXHOSTNAMELEN
@@ -178,6 +178,7 @@ static char *myhostname (void)
        return (name);
 }
 
+#if HAVE_INNETGR
 /* netgroup_match - match group against machine or user */
 static int
 netgroup_match (const char *group, const char *machine, const char *user)
@@ -193,6 +194,7 @@ netgroup_match (const char *group, const char *machine, const char *user)
 
        return innetgr (group, machine, user, mydomain);
 }
+#endif
 
 /* user_match - match a username against one token */
 static int user_match (const char *tok, const char *string)
@@ -214,8 +216,10 @@ static int user_match (const char *tok, const char *string)
                *at = 0;
                return (user_match (tok, string)
                        && from_match (at + 1, myhostname ()));
+#if HAVE_INNETGR
        } else if (tok[0] == '@') {     /* netgroup */
                return (netgroup_match (tok + 1, (char *) 0, string));
+#endif
        } else if (string_match (tok, string)) {        /* ALL or exact match */
                return (YES);
        } else if ((group = getgrnam (tok))) {  /* try group membership */
@@ -271,9 +275,12 @@ static int from_match (const char *tok, const char *string)
         * contain a "." character. If the token is a network number, return YES
         * if it matches the head of the string.
         */
+#if HAVE_INNETGR
        if (tok[0] == '@') {    /* netgroup */
                return (netgroup_match (tok + 1, string, (char *) 0));
-       } else if (string_match (tok, string)) {        /* ALL or exact match */
+       } else
+#endif
+       if (string_match (tok, string)) {       /* ALL or exact match */
                return (YES);
        } else if (tok[0] == '.') {     /* domain: match last fields */
                if ((str_len = strlen (string)) > (tok_len = strlen (tok))