Fix a very minor oversight in privileges-elevation: we were only considering

friendship for a derived class if the base class specifier was non-public,
and thus not considering friendship for non-public members of public bases.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@99554 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaAccess.cpp b/lib/Sema/SemaAccess.cpp
index 196bc117791f856ae38cc9f337a7fd84e197e967..a92989696e3101982144faa0470e9fcee536997f 100644 (file)
--- a/lib/Sema/SemaAccess.cpp
+++ b/lib/Sema/SemaAccess.cpp
@@ -429,7 +429,7 @@ static CXXBasePath *FindBestPath(Sema &S,
       }
 
       AccessSpecifier BaseAccess = I->Base->getAccessSpecifier();
-      if (BaseAccess != AS_public) {
+      if (BaseAccess != AS_public || PathAccess != AS_public) {
         switch (GetFriendKind(S, EC, I->Class)) {
         case Sema::AR_inaccessible:
           PathAccess = CXXRecordDecl::MergeAccess(BaseAccess, PathAccess);

diff --git a/test/CXX/class.access/class.friend/p1.cpp b/test/CXX/class.access/class.friend/p1.cpp
index 851cd3d0088479f594b6a74eacf618d635cea9a1..d9c23c110d5f0719177bfbea4f3d8233bdcbfa93 100644 (file)
--- a/test/CXX/class.access/class.friend/p1.cpp
+++ b/test/CXX/class.access/class.friend/p1.cpp
@@ -149,3 +149,19 @@ namespace test2 {
     // expected-error {{'getNext' is a private member of 'test2::ilist_node'}}
   };  
 }
+
+namespace test3 {
+  class A { protected: int x; }; // expected-note {{declared protected here}}
+
+  class B : public A {
+    friend int foo(B*);
+  };
+
+  int foo(B *p) {
+    return p->x;
+  }
+
+  int foo(const B *p) {
+    return p->x; // expected-error {{'x' is a protected member of 'test3::A'}}
+  }
+}