Fix use of free in walsender error handling after a sysid mismatch.

Found via valgrind. The bug exists since the introduction of the walsender,
so backpatch to 9.0.

Andres Freund

diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index 0831b1b2ded28085a7de828c56489dfd331608e6..85aa12714c5cf497b085bb31c3b22f72b375dc2a 100644 (file)
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -135,6 +135,7 @@ libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)
                         GetSystemIdentifier());
        if (strcmp(primary_sysid, standby_sysid) != 0)
        {
+               primary_sysid = pstrdup(primary_sysid);
                PQclear(res);
                ereport(ERROR,
                                (errmsg("database system identifier differs between the primary and standby"),