Update get_class_name semantics

 * get_class_name is now only used for displaying the class name
   in debugging functions like var_dump, print_r, etc. It is no
   longer used in get_class() etc.
 * As it is no longer used in get_parent_class() the parent
   argument is now gone. This also fixes incorrect parent classes
   being reported in COM.
 * get_class_name is now always required (previously some places
   made it optional and some required it) and is also required
   to return a non-NULL value.
 * Remove zend_get_object_classname. This also fixes a number of
   potential leaks due to incorrect usage of this function.

diff --git a/Zend/zend.c b/Zend/zend.c
index eb91026a2434026cdc9b8bf129097cd68ad5f0f5..7fef34c94ec62de2c0f7ea69eb24157a4c41f369 100644 (file)
--- a/Zend/zend.c
+++ b/Zend/zend.c
@@ -263,19 +263,10 @@ ZEND_API void zend_print_flat_zval_r(zval *expr TSRMLS_DC) /* {{{ */
                case IS_OBJECT:
                {
                        HashTable *properties = NULL;
-                       zend_string *class_name = NULL;
+                       zend_string *class_name = Z_OBJ_HANDLER_P(expr, get_class_name)(Z_OBJ_P(expr) TSRMLS_CC);
+                       zend_printf("%s Object (", class_name->val);
+                       zend_string_release(class_name);
 
-                       if (Z_OBJ_HANDLER_P(expr, get_class_name)) {
-                               class_name = Z_OBJ_HANDLER_P(expr, get_class_name)(Z_OBJ_P(expr), 0 TSRMLS_CC);
-                       }
-                       if (class_name) {
-                               zend_printf("%s Object (", class_name->val);
-                       } else {
-                               zend_printf("%s Object (", "Unknown Class");
-                       }
-                       if (class_name) {
-                               zend_string_release(class_name);
-                       }
                        if (Z_OBJ_HANDLER_P(expr, get_properties)) {
                                properties = Z_OBJPROP_P(expr);
                        }
@@ -324,21 +315,13 @@ ZEND_API void zend_print_zval_r_ex(zend_write_func_t write_func, zval *expr, int
                case IS_OBJECT:
                        {
                                HashTable *properties;
-                               zend_string *class_name = NULL;
                                int is_temp;
 
-                               if (Z_OBJ_HANDLER_P(expr, get_class_name)) {
-                                       class_name = Z_OBJ_HANDLER_P(expr, get_class_name)(Z_OBJ_P(expr), 0 TSRMLS_CC);
-                               }
-                               if (class_name) {
-                                       ZEND_PUTS_EX(class_name->val);
-                               } else {
-                                       ZEND_PUTS_EX("Unknown Class");
-                               }
+                               zend_string *class_name = Z_OBJ_HANDLER_P(expr, get_class_name)(Z_OBJ_P(expr) TSRMLS_CC);
+                               ZEND_PUTS_EX(class_name->val);
+                               zend_string_release(class_name);
+
                                ZEND_PUTS_EX(" Object\n");
-                               if (class_name) {
-                                       zend_string_release(class_name);
-                               }
                                if ((properties = Z_OBJDEBUG_P(expr, is_temp)) == NULL) {
                                        break;
                                }

diff --git a/Zend/zend_API.c b/Zend/zend_API.c
index cf4ac5effd57f55cd7fdfd2e2d34e0e12621e5bb..dd60dcb5fb13e03d984a129848c855475f3e7d62 100644 (file)
--- a/Zend/zend_API.c
+++ b/Zend/zend_API.c
@@ -196,21 +196,6 @@ ZEND_API char *zend_zval_type_name(const zval *arg) /* {{{ */
 }
 /* }}} */
 
-/* returns 1 if you need to copy result, 0 if it's already a copy */
-ZEND_API zend_string *zend_get_object_classname(const zend_object *object TSRMLS_DC) /* {{{ */
-{
-       zend_string *ret;
-
-       if (object->handlers->get_class_name != NULL) {
-               ret = object->handlers->get_class_name(object, 0 TSRMLS_CC);
-               if (ret) {
-                       return ret;
-               }
-       }
-       return object->ce->name;
-}
-/* }}} */
-
 static int parse_arg_object_to_string(zval *arg, char **p, size_t *pl, int type TSRMLS_DC) /* {{{ */
 {
        if (Z_OBJ_HANDLER_P(arg, cast_object)) {
@@ -3814,8 +3799,7 @@ ZEND_API void zend_update_property(zend_class_entry *scope, zval *object, const
        EG(scope) = scope;
 
        if (!Z_OBJ_HT_P(object)->write_property) {
-               zend_string *class_name = zend_get_object_classname(Z_OBJ_P(object) TSRMLS_CC);
-               zend_error(E_CORE_ERROR, "Property %s of class %s cannot be updated", name, class_name->val);
+               zend_error(E_CORE_ERROR, "Property %s of class %s cannot be updated", name, Z_OBJCE_P(object)->name->val);
        }
        ZVAL_STRINGL(&property, name, name_length);
        Z_OBJ_HT_P(object)->write_property(object, &property, value, NULL TSRMLS_CC);
@@ -3994,8 +3978,7 @@ ZEND_API zval *zend_read_property(zend_class_entry *scope, zval *object, const c
        EG(scope) = scope;
 
        if (!Z_OBJ_HT_P(object)->read_property) {
-               zend_string *class_name = zend_get_object_classname(Z_OBJ_P(object) TSRMLS_CC);
-               zend_error(E_CORE_ERROR, "Property %s of class %s cannot be read", name, class_name->val);
+               zend_error(E_CORE_ERROR, "Property %s of class %s cannot be read", name, Z_OBJCE_P(object)->name->val);
        }
 
        ZVAL_STRINGL(&property, name, name_length);

diff --git a/Zend/zend_API.h b/Zend/zend_API.h
index 9082c035f64c89f35f526438f048be82e65cb3ad..b73dcd4c6503625263e2aa987667539f370705ca 100644 (file)
--- a/Zend/zend_API.h
+++ b/Zend/zend_API.h
@@ -339,7 +339,6 @@ ZEND_API zval *zend_read_property(zend_class_entry *scope, zval *object, const c
 
 ZEND_API zval *zend_read_static_property(zend_class_entry *scope, const char *name, int name_length, zend_bool silent TSRMLS_DC);
 
-ZEND_API zend_string *zend_get_object_classname(const zend_object *object TSRMLS_DC);
 ZEND_API char *zend_get_type_by_const(int type);
 
 #define getThis()                                                      (Z_OBJ(EX(This)) ? &EX(This) : NULL)

diff --git a/Zend/zend_builtin_functions.c b/Zend/zend_builtin_functions.c
index fb85a2d61378cf466828341c342e5ed2ffbfe7a9..9487bb6c1e417170c41be3158f1e6378fd6a8b86 100644 (file)
--- a/Zend/zend_builtin_functions.c
+++ b/Zend/zend_builtin_functions.c
@@ -811,7 +811,7 @@ ZEND_FUNCTION(get_class)
                }
        }
 
-       RETURN_STR(zend_get_object_classname(Z_OBJ_P(obj) TSRMLS_CC));
+       RETURN_STR(zend_string_copy(Z_OBJCE_P(obj)->name));
 }
 /* }}} */
 
@@ -838,7 +838,6 @@ ZEND_FUNCTION(get_parent_class)
 {
        zval *arg;
        zend_class_entry *ce = NULL;
-       zend_string *name;
        
        if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|z", &arg) == FAILURE) {
                return;
@@ -854,12 +853,7 @@ ZEND_FUNCTION(get_parent_class)
        }
 
        if (Z_TYPE_P(arg) == IS_OBJECT) {
-               if (Z_OBJ_HT_P(arg)->get_class_name
-                       && (name = Z_OBJ_HT_P(arg)->get_class_name(Z_OBJ_P(arg), 1 TSRMLS_CC)) != NULL) {
-                       RETURN_STR(name);
-               } else {
-                       ce = Z_OBJ_P(arg)->ce;
-               }
+               ce = Z_OBJ_P(arg)->ce;
        } else if (Z_TYPE_P(arg) == IS_STRING) {
            ce = zend_lookup_class(Z_STR_P(arg) TSRMLS_CC);
        }
@@ -2194,7 +2188,7 @@ ZEND_FUNCTION(debug_print_backtrace)
                                if (func->common.scope) {
                                        class_name = func->common.scope->name;
                                } else {
-                                       class_name = zend_get_object_classname(object TSRMLS_CC);
+                                       class_name = object->ce->name;
                                }
 
                                call_type = "->";
@@ -2301,7 +2295,6 @@ ZEND_API void zend_fetch_debug_backtrace(zval *return_value, int skip_last, int
        zend_function *func;
        const char *function_name;
        const char *filename;
-       zend_string *class_name;
        const char *include_filename = NULL;
        zval stack_frame;
 
@@ -2416,8 +2409,7 @@ ZEND_API void zend_fetch_debug_backtrace(zval *return_value, int skip_last, int
                                if (func->common.scope) {
                                        add_assoc_str_ex(&stack_frame, "class", sizeof("class")-1, zend_string_copy(func->common.scope->name));
                                } else {
-                                       class_name = zend_get_object_classname(object TSRMLS_CC);
-                                       add_assoc_str_ex(&stack_frame, "class", sizeof("class")-1, zend_string_copy(class_name));
+                                       add_assoc_str_ex(&stack_frame, "class", sizeof("class")-1, zend_string_copy(object->ce->name));
                                        
                                }
                                if ((options & DEBUG_BACKTRACE_PROVIDE_OBJECT) != 0) {

diff --git a/Zend/zend_exceptions.c b/Zend/zend_exceptions.c
index 6e4ee2fd302e5db3c9e4b15e74fc8657e8ac7460..f9c1a509a6ca4fc6ff80b52594de093a269cce90 100644 (file)
--- a/Zend/zend_exceptions.c
+++ b/Zend/zend_exceptions.c
@@ -89,11 +89,8 @@ ZEND_API void zend_throw_exception_internal(zval *exception TSRMLS_DC) /* {{{ */
 {
 #ifdef HAVE_DTRACE
        if (DTRACE_EXCEPTION_THROWN_ENABLED()) {
-               zend_string *classname;
-
                if (exception != NULL) {
-                       classname = zend_get_object_classname(Z_OBJ_P(exception) TSRMLS_CC);
-                       DTRACE_EXCEPTION_THROWN(classname->val);
+                       DTRACE_EXCEPTION_THROWN(Z_OBJ_P(exception)->ce->val);
                } else {
                        DTRACE_EXCEPTION_THROWN(NULL);
                }
@@ -452,7 +449,7 @@ static void _build_trace_args(zval *arg, smart_str *str TSRMLS_DC) /* {{{ */
                        break;
                case IS_OBJECT:
                        smart_str_appends(str, "Object(");
-                       smart_str_append(str, zend_get_object_classname(Z_OBJ_P(arg) TSRMLS_CC));
+                       smart_str_append(str, Z_OBJCE_P(arg)->name);
                        smart_str_appends(str, "), ");
                        break;
        }

diff --git a/Zend/zend_object_handlers.c b/Zend/zend_object_handlers.c
index c02cda64b9959322dd64939dbca07c517650b313..6679cb1e46763b689deb2927add77cd5b48caeab 100644 (file)
--- a/Zend/zend_object_handlers.c
+++ b/Zend/zend_object_handlers.c
@@ -1525,20 +1525,9 @@ exit:
 }
 /* }}} */
 
-zend_string* zend_std_object_get_class_name(const zend_object *zobj, int parent TSRMLS_DC) /* {{{ */
+zend_string *zend_std_object_get_class_name(const zend_object *zobj TSRMLS_DC) /* {{{ */
 {
-       zend_class_entry *ce;
-
-       if (parent) {
-               if (!zobj->ce->parent) {
-                       return NULL;
-               }
-               ce = zobj->ce->parent;
-       } else {
-               ce = zobj->ce;
-       }
-
-       return zend_string_copy(ce->name);
+       return zend_string_copy(zobj->ce->name);
 }
 /* }}} */
 

diff --git a/Zend/zend_object_handlers.h b/Zend/zend_object_handlers.h
index 623282b43d78e9e96198abb5a694a6888ef2204e..2b06ebdf3da737212505641faef29ac9c8d0fec9 100644 (file)
--- a/Zend/zend_object_handlers.h
+++ b/Zend/zend_object_handlers.h
@@ -95,7 +95,10 @@ typedef void (*zend_object_dtor_obj_t)(zend_object *object TSRMLS_DC);
 typedef void (*zend_object_free_obj_t)(zend_object *object TSRMLS_DC);
 typedef zend_object* (*zend_object_clone_obj_t)(zval *object TSRMLS_DC);
 
-typedef zend_string *(*zend_object_get_class_name_t)(const zend_object *object, int parent TSRMLS_DC);
+/* Get class name for display in var_dump and other debugging functions.
+ * Must be defined and must return a non-NULL value. */
+typedef zend_string *(*zend_object_get_class_name_t)(const zend_object *object TSRMLS_DC);
+
 typedef int (*zend_object_compare_t)(zval *object1, zval *object2 TSRMLS_DC);
 typedef int (*zend_object_compare_zvals_t)(zval *resul, zval *op1, zval *op2 TSRMLS_DC);
 

diff --git a/ext/com_dotnet/com_handlers.c b/ext/com_dotnet/com_handlers.c
index 607b2e08f365f79edb0638212bfb80d96a1dbffd..6f63a1fbd8888a9a202a936e35bccafbae7c9419 100644 (file)
--- a/ext/com_dotnet/com_handlers.c
+++ b/ext/com_dotnet/com_handlers.c
@@ -423,7 +423,7 @@ static union _zend_function *com_constructor_get(zend_object *object TSRMLS_DC)
        }
 }
 
-static zend_string* com_class_name_get(const zend_object *object, int parent TSRMLS_DC)
+static zend_string* com_class_name_get(const zend_object *object TSRMLS_DC)
 {
        php_com_dotnet_object *obj = (php_com_dotnet_object *)object;
 

diff --git a/ext/com_dotnet/com_saproxy.c b/ext/com_dotnet/com_saproxy.c
index e4d3ebb7df30f9e025397f355194b41aec97daaa..ddee9bc179596a28eca84f406a6f43a98d3e235b 100644 (file)
--- a/ext/com_dotnet/com_saproxy.c
+++ b/ext/com_dotnet/com_saproxy.c
@@ -333,7 +333,7 @@ static union _zend_function *saproxy_constructor_get(zend_object *object TSRMLS_
        return NULL;
 }
 
-static zend_string* saproxy_class_name_get(const zend_object *object, int parent TSRMLS_DC)
+static zend_string* saproxy_class_name_get(const zend_object *object TSRMLS_DC)
 {
        return zend_string_copy(php_com_saproxy_class_entry->name);
 }

diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c
index 32f06b5dfa728dd52fb73d0ab041433354720687..705d08bacf582db893bb8622139508ece23dfe66 100644 (file)
--- a/ext/pdo/pdo_stmt.c
+++ b/ext/pdo/pdo_stmt.c
@@ -2636,13 +2636,9 @@ static union _zend_function *row_get_ctor(zend_object *object TSRMLS_DC)
        return (union _zend_function*)&ctor;
 }
 
-static zend_string *row_get_classname(const zend_object *object, int parent TSRMLS_DC)
+static zend_string *row_get_classname(const zend_object *object TSRMLS_DC)
 {
-       if (parent) {
-               return NULL;
-       } else {
-               return zend_string_init("PDORow", sizeof("PDORow") - 1, 0);
-       }
+       return zend_string_init("PDORow", sizeof("PDORow") - 1, 0);
 }
 
 static int row_compare(zval *object1, zval *object2 TSRMLS_DC)

diff --git a/ext/standard/php_incomplete_class.h b/ext/standard/php_incomplete_class.h
index 7be152f1c0bf23de81d067fd57bcee8eca7f981b..177e960765c256f429f4923380898b830d59baae 100644 (file)
--- a/ext/standard/php_incomplete_class.h
+++ b/ext/standard/php_incomplete_class.h
@@ -35,7 +35,7 @@
                } \
                incomplete_class = 1; \
        } else { \
-               class_name = zend_get_object_classname(Z_OBJ_P(struc) TSRMLS_CC); \
+               class_name = zend_string_copy(Z_OBJCE_P(struc)->name); \
        }
 
 #define PHP_CLEANUP_CLASS_ATTRIBUTES() \

diff --git a/ext/standard/var.c b/ext/standard/var.c
index f7ac7065c35bffbca404df995fc97c7b088a5db4..6e5bd703d36ec9038c03c835306b47520f6d5444 100644 (file)
--- a/ext/standard/var.c
+++ b/ext/standard/var.c
@@ -163,13 +163,10 @@ again:
                                return;
                        }
 
-                       if (Z_OBJ_HANDLER_P(struc, get_class_name)) {
-                               class_name = Z_OBJ_HANDLER_P(struc, get_class_name)(Z_OBJ_P(struc), 0 TSRMLS_CC);
-                               php_printf("%sobject(%s)#%d (%d) {\n", COMMON, class_name->val, Z_OBJ_HANDLE_P(struc), myht ? zend_obj_num_elements(myht) : 0);
-                               zend_string_release(class_name);
-                       } else {
-                               php_printf("%sobject(unknown class)#%d (%d) {\n", COMMON, Z_OBJ_HANDLE_P(struc), myht ? zend_obj_num_elements(myht) : 0);
-                       }
+                       class_name = Z_OBJ_HANDLER_P(struc, get_class_name)(Z_OBJ_P(struc) TSRMLS_CC);
+                       php_printf("%sobject(%s)#%d (%d) {\n", COMMON, class_name->val, Z_OBJ_HANDLE_P(struc), myht ? zend_obj_num_elements(myht) : 0);
+                       zend_string_release(class_name);
+
                        if (myht) {
                                zend_ulong num;
                                zend_string *key;
@@ -334,7 +331,7 @@ again:
                                myht->u.v.nApplyCount++;
                        }
                }
-               class_name = Z_OBJ_HANDLER_P(struc, get_class_name)(Z_OBJ_P(struc), 0 TSRMLS_CC);
+               class_name = Z_OBJ_HANDLER_P(struc, get_class_name)(Z_OBJ_P(struc) TSRMLS_CC);
                php_printf("%sobject(%s)#%d (%d) refcount(%u){\n", COMMON, class_name->val, Z_OBJ_HANDLE_P(struc), myht ? zend_obj_num_elements(myht) : 0, Z_REFCOUNT_P(struc));
                zend_string_release(class_name);
                if (myht) {
@@ -456,7 +453,6 @@ PHPAPI void php_var_export_ex(zval *struc, int level, smart_str *buf TSRMLS_DC)
        HashTable *myht;
        char *tmp_str;
        size_t tmp_len;
-       zend_string *class_name;
        zend_string *ztmp, *ztmp2;
        zend_ulong index;
        zend_string *key;
@@ -533,12 +529,10 @@ again:
                                smart_str_appendc(buf, '\n');
                                buffer_append_spaces(buf, level - 1);
                        }
-                       class_name = Z_OBJ_HANDLER_P(struc, get_class_name)(Z_OBJ_P(struc), 0 TSRMLS_CC);
 
-                       smart_str_append(buf, class_name);
+                       smart_str_append(buf, Z_OBJCE_P(struc)->name);
                        smart_str_appendl(buf, "::__set_state(array(\n", 21);
 
-                       zend_string_release(class_name);
                        if (myht) {
                                ZEND_HASH_FOREACH_KEY_VAL_IND(myht, index, key, val) {
                                        php_object_element_export(val, index, key, level, buf TSRMLS_CC);