#16664: Add regression tests for glob's behaviour concerning "."-entries

Patch by Sebastian Kreft.

diff --git a/Lib/test/test_glob.py b/Lib/test/test_glob.py
index 1560a6bbf0b1b45895f006caf428a5ceb9a441fa..711369e289b35fbd990d28a1f8550d40f90b4572 100644 (file)
--- a/Lib/test/test_glob.py
+++ b/Lib/test/test_glob.py
@@ -4,6 +4,7 @@ import glob
 import os
 import shutil
 
+
 class GlobTests(unittest.TestCase):
 
     def norm(self, *parts):
@@ -18,9 +19,11 @@ class GlobTests(unittest.TestCase):
         f.close()
 
     def setUp(self):
-        self.tempdir = TESTFN+"_dir"
+        self.tempdir = TESTFN + "_dir"
         self.mktemp('a', 'D')
         self.mktemp('aab', 'F')
+        self.mktemp('.aa', 'G')
+        self.mktemp('.bb', 'H')
         self.mktemp('aaa', 'zzzF')
         self.mktemp('ZZZ')
         self.mktemp('a', 'bcd', 'EF')
@@ -66,6 +69,8 @@ class GlobTests(unittest.TestCase):
         eq = self.assertSequencesEqual_noorder
         eq(self.glob('a*'), map(self.norm, ['a', 'aab', 'aaa']))
         eq(self.glob('*a'), map(self.norm, ['a', 'aaa']))
+        eq(self.glob('.*'), map(self.norm, ['.aa', '.bb']))
+        eq(self.glob('?aa'), map(self.norm, ['aaa']))
         eq(self.glob('aa?'), map(self.norm, ['aaa', 'aab']))
         eq(self.glob('aa[ab]'), map(self.norm, ['aaa', 'aab']))
         eq(self.glob('*q'), [])

diff --git a/Misc/ACKS b/Misc/ACKS
index 424e72a7dc5119bd82ec99e63a04fb0b8cfc8842..81af9fdd44dba49c4eb026ee1b56ecad1500b2bf 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -587,6 +587,7 @@ Jerzy Kozera
 Maksim Kozyarchuk
 Stefan Krah
 Bob Kras
+Sebastian Kreft
 Holger Krekel
 Michael Kremer
 Fabian Kreutz

diff --git a/Misc/NEWS b/Misc/NEWS
index 57cab2d77e566bb4afcb63dfd09375fd8e5bfbdc..c5288f76e6149d54aa4d8e64d1cabe75e98eee1f 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -689,6 +689,9 @@ Extension Modules
 Tests
 -----
 
+- Issue #16664: Add regression tests for glob's behaviour concerning entries
+  starting with a ".".  Patch by Sebastian Kreft.
+
 - Issue #15872: Add tests for a 3.3 regression which caused the new fd-based
   shutil.rmtree not ignore all errors. Also add a test ensuring that rmtree
   fails when being called on a symlink. Patch by Serhiy Storchaka.