When Perl "kill(9, ...)" fails, try "pg_ctl kill".

Per buildfarm member jacana, the former fails under msys Perl 5.8.8.
Back-patch to 9.6, like the code in question.

Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@yesql.se

diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index 0335ab22f27b4572b3d01db901ebf6cc3c74b397..e8dc3f73e3a4801f8aea7194b7c48fb3f60c909c 100644 (file)
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -777,7 +777,9 @@ sub kill9
        my $name = $self->name;
        return unless defined $self->{_pid};
        print "### Killing node \"$name\" using signal 9\n";
-       kill(9, $self->{_pid}) or BAIL_OUT("kill(9, $self->{_pid}) failed");
+       # kill(9, ...) fails under msys Perl 5.8.8, so fall back on pg_ctl.
+       kill(9, $self->{_pid})
+         or TestLib::system_or_bail('pg_ctl', 'kill', 'KILL', $self->{_pid});
        $self->{_pid} = undef;
        return;
 }