Fixed null values fraction computation in geometry analyzer as suggested by Michael...

git-svn-id: http://svn.osgeo.org/postgis/branches/pgis_1_0@1960 b70326c6-7e19-0410-871a-916f4a2858ee

diff --git a/CHANGES b/CHANGES
index 8ab3257a5544a2a0d3bd560b0c2609d7869132b0..bf61f97fc61d0016945adf915935d3eb018d1f0a 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,7 @@
 PostGIS 1.0.5CVS
        - New "Reporting Bugs" chapter in manual
        - Segfault fix in shp2pgsql (utf8 encoding)
+       - Fixed computation of null values fraction in analyzer
 
 PostGIS 1.0.4
 2005/09/09

diff --git a/lwgeom/lwgeom_estimate.c b/lwgeom/lwgeom_estimate.c
index 504cec7f46681335b0ea5f1814b8c53cdb2b57da..fe1eca2400ff3b31c258cb61fa5a68e7c655e81f 100644 (file)
--- a/lwgeom/lwgeom_estimate.c
+++ b/lwgeom/lwgeom_estimate.c
@@ -2262,7 +2262,7 @@ compute_geometry_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
        stats->stanumbers[0] = (float4 *)geomstats;
        stats->numnumbers[0] = geom_stats_size/sizeof(float4);
 
-       stats->stanullfrac = null_cnt/samplerows;
+       stats->stanullfrac = (float4)null_cnt/samplerows;
        stats->stawidth = total_width/notnull_cnt;
        stats->stadistinct = -1.0;
 
@@ -2271,7 +2271,7 @@ compute_geometry_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
                stats->stakind[0]);
        elog(NOTICE, " out: slot 0: op %d (InvalidOid)", stats->staop[0]);
        elog(NOTICE, " out: slot 0: numnumbers %d", stats->numnumbers[0]);
-       elog(NOTICE, " out: null fraction: %d/%d", null_cnt, samplerows);
+       elog(NOTICE, " out: null fraction: %d/%d=%g", null_cnt, samplerows, stats->stanullfrac);
        elog(NOTICE, " out: average width: %d bytes", stats->stawidth);
        elog(NOTICE, " out: distinct values: all (no check done)");
 #endif
@@ -2510,6 +2510,9 @@ Datum LWGEOM_estimated_extent(PG_FUNCTION_ARGS)
 
 /**********************************************************************
  * $Log$
+ * Revision 1.29.2.6  2005/10/10 16:19:07  strk
+ * Fixed null values fraction computation in geometry analyzer as suggested by Michael Fuhr
+ *
  * Revision 1.29.2.5  2005/09/08 19:26:10  strk
  * Handled search_box outside of histogram_box case in selectivity estimator
  *