Merged revisions 78014 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r78014 | r.david.murray | 2010-02-05 23:27:21 -0500 (Fri, 05 Feb 2010) | 5 lines

  issue #7728: test_timeout was using a hardcoded port, which was
  causing buildbot failures.  Changed to use test_support.bind_port.
  Patch by Florent Xicluna.
........

diff --git a/Lib/test/test_timeout.py b/Lib/test/test_timeout.py
index 02687b07427d64cfd4119958433ba0f4e5f0d343..460e0d65723fe7246b6e15d38237989a238cd3a9 100644 (file)
--- a/Lib/test/test_timeout.py
+++ b/Lib/test/test_timeout.py
@@ -101,7 +101,7 @@ class TimeoutTestCase(unittest.TestCase):
     def setUp(self):
         self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         self.addr_remote = ('www.python.org.', 80)
-        self.addr_local  = ('127.0.0.1', 25339)
+        self.localhost = '127.0.0.1'
 
     def tearDown(self):
         self.sock.close()
@@ -146,7 +146,8 @@ class TimeoutTestCase(unittest.TestCase):
         # Test accept() timeout
         _timeout = 2
         self.sock.settimeout(_timeout)
-        self.sock.bind(self.addr_local)
+        # Prevent "Address already in use" socket exceptions
+        test_support.bind_port(self.sock, self.localhost)
         self.sock.listen(5)
 
         _t1 = time.time()
@@ -163,7 +164,8 @@ class TimeoutTestCase(unittest.TestCase):
         _timeout = 2
         self.sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
         self.sock.settimeout(_timeout)
-        self.sock.bind(self.addr_local)
+        # Prevent "Address already in use" socket exceptions
+        test_support.bind_port(self.sock, self.localhost)
 
         _t1 = time.time()
         self.failUnlessRaises(socket.error, self.sock.recvfrom, 8192)

diff --git a/Misc/NEWS b/Misc/NEWS
index eaa82df5de21d3f4cd356c536338d584f0fbab67..42ef1e097ebdc0ec59fc1c251a7e9e12370f765b 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -238,6 +238,9 @@ Documentation
 Tests
 -----
 
+- issue #7728: test_timeout was changed to use test_support.bind_port
+  instead of a hard coded port.
+
 - Issue #7498: test_multiprocessing now uses test_support.find_unused_port
   instead of a hardcoded port number in test_rapid_restart.