getrusage.c was easy(). But don't ever use zend_parse_parameters() like

that.

diff --git a/ext/standard/microtime.c b/ext/standard/microtime.c
index 449ecc133af3c2530735170034ce1b147ddba32f..6f58000f4b53a4c9a30407db0f4626a73d8c2926 100644 (file)
--- a/ext/standard/microtime.c
+++ b/ext/standard/microtime.c
@@ -107,7 +107,7 @@ PHP_FUNCTION(gettimeofday)
 /* }}} */
 
 #ifdef HAVE_GETRUSAGE
-/* {{{ proto array getrusage([int who])
+/* {{{ proto array getrusage([int who]) U
    Returns an array of usage statistics */
 PHP_FUNCTION(getrusage)
 {
@@ -115,7 +115,11 @@ PHP_FUNCTION(getrusage)
        long pwho = 0;
        int who = RUSAGE_SELF;
 
-       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|l", &pwho) != FAILURE && pwho == 1) {
+       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|l", &pwho) == FAILURE) {
+          return;
+       }
+
+       if (pwho == 1) {
                who = RUSAGE_CHILDREN;
        }