Fix incorrect strncmp() lengths. The check for USERNAME was only

looking at the first 5 characters (copy and paste error).  The check
for SUDO_PS1 was not checking the trailing '=' character (off by
one error).  Found by PVS-Studio.

diff --git a/plugins/sudoers/env.c b/plugins/sudoers/env.c
index 22e0b7d0a5f877f80fbcd5057a04d5a5e6815da2..8ba353b440ff7eea1a465757f34cd3941cdc4e74 100644 (file)
--- a/plugins/sudoers/env.c
+++ b/plugins/sudoers/env.c
@@ -817,7 +817,7 @@ env_update_didvar(const char *ep, unsigned int *didvar)
        case 'U':
            if (strncmp(ep, "USER=", 5) == 0)
                SET(*didvar, DID_USER);
-           if (strncmp(ep, "USERNAME=", 5) == 0)
+           if (strncmp(ep, "USERNAME=", 9) == 0)
                SET(*didvar, DID_USERNAME);
            break;
     }
@@ -918,7 +918,7 @@ rebuild_env(void)
             * Do SUDO_PS1 -> PS1 conversion.
             * This must happen *after* env_should_keep() is called.
             */
-           if (strncmp(*ep, "SUDO_PS1=", 8) == 0)
+           if (strncmp(*ep, "SUDO_PS1=", 9) == 0)
                ps1 = *ep + 5;
 
            if (keepit) {