SF bug 563750 (Alex Martelli): posix_tmpfile():

The file returned by tmpfile() has mode w+b, so use that in the call
to PyFile_FromFile().

Bugfix candidate.

diff --git a/Doc/lib/libos.tex b/Doc/lib/libos.tex
index aafe7b19775b14663a0b6c892b1734609ddc8dab..c02d6a6e5dd6a11a35f61ad95a9c31cf0dcb1292 100644 (file)
--- a/Doc/lib/libos.tex
+++ b/Doc/lib/libos.tex
@@ -312,7 +312,7 @@ Availability: \UNIX, Windows.
 \end{funcdesc}
 
 \begin{funcdesc}{tmpfile}{}
-Return a new file object opened in update mode (\samp{w+}).  The file
+Return a new file object opened in update mode (\samp{w+b}).  The file
 has no directory entries associated with it and will be automatically
 deleted once there are no file descriptors for the file.
 Availability: \UNIX, Windows.

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 9d7c3c20a3ebf49617666b44cd2c51385e5c69e4..95f4613ac346d5ee34808eff49d5ba2a758d98a7 100644 (file)
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5194,7 +5194,7 @@ posix_tmpfile(PyObject *self, PyObject *args)
     fp = tmpfile();
     if (fp == NULL)
         return posix_error();
-    return PyFile_FromFile(fp, "<tmpfile>", "w+", fclose);
+    return PyFile_FromFile(fp, "<tmpfile>", "w+b", fclose);
 }
 #endif