Add a comment/FIXME so Eli can sleep better:-))

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68379 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp
index 1bf73db177c4d3061645e8752096b45d0fec6ca0..b92776face028e072a09b2cb654384ab26292ddc 100644 (file)
--- a/lib/CodeGen/CodeGenModule.cpp
+++ b/lib/CodeGen/CodeGenModule.cpp
@@ -1039,6 +1039,11 @@ GetAddrOfConstantCFString(const StringLiteral *Literal) {
                                 strictConversion);
     assert(Result == conversionOK && "UTF-8 to UTF-16 conversion failed");
     
+    // FIXME: Storing UTF-16 in a C string is a hack to test Unicode strings
+    // without doing more surgery to this routine. Since we aren't explicitly
+    // checking for endianness here, it's also a bug (when generating code for
+    // a target that doesn't match the host endianness). Modeling this as an i16
+    // array is likely the cleanest solution.
     StringLength = ToPtr-&ToBuf[0];
     str.assign((char *)&ToBuf[0], StringLength*2); // Twice as many UTF8 chars.
     isUTF16 = true;