]> granicus.if.org Git - php/commitdiff
Fixed Bug #69874 : Can't set empty additional_headers for mail()
authorYasuo Ohgaki <yohgaki@php.net>
Fri, 19 Jun 2015 03:19:02 +0000 (12:19 +0900)
committerYasuo Ohgaki <yohgaki@php.net>
Fri, 19 Jun 2015 03:19:12 +0000 (12:19 +0900)
ext/standard/mail.c
ext/standard/tests/mail/bug69874.phpt [new file with mode: 0644]

index 448013a472a3466245e64b1cb37a9d1b0f7c007e..1c1332b55e26e05e509e740244079ea20f85c11f 100644 (file)
@@ -320,7 +320,7 @@ PHPAPI int php_mail(char *to, char *subject, char *message, char *headers, char
                efree(f);
        }
 
-       if (hdr && php_mail_detect_multiple_crlf(hdr)) {
+       if (hdr && strlen(hdr) && php_mail_detect_multiple_crlf(hdr)) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Multiple or malformed newlines found in additional_header");
                MAIL_RET(0);
        }
diff --git a/ext/standard/tests/mail/bug69874.phpt b/ext/standard/tests/mail/bug69874.phpt
new file mode 100644 (file)
index 0000000..a952a73
--- /dev/null
@@ -0,0 +1,42 @@
+--TEST--
+Bug #69874: Null addtional_headers does not send mail
+--INI--
+sendmail_path=tee mailBasic.out >/dev/null
+mail.add_x_header = Off
+--SKIPIF--
+<?php
+if(substr(PHP_OS, 0, 3) == "WIN")
+  die("skip Won't run on Windows");
+?>
+--FILE--
+<?php
+/* Prototype  : int mail(string to, string subject, string message [, string additional_headers [, string additional_parameters]])
+ * Description: Send an email message
+ * Source code: ext/standard/mail.c
+ * Alias to functions:
+ */
+
+echo "*** Testing mail() : send email without additional headers ***\n";
+
+// Initialise all required variables
+$to = 'user@company.com';
+$subject = 'Test Subject';
+$message = 'A Message';
+
+$outFile = "mailBasic.out";
+@unlink($outFile);
+
+var_dump( mail($to, $subject, $message) );
+echo file_get_contents($outFile);
+unlink($outFile);
+
+?>
+===DONE===
+--EXPECTF--
+*** Testing mail() : send email without additional headers ***
+bool(true)
+To: user@company.com
+Subject: Test Subject
+
+A Message
+===DONE===