Don't globber scoreboard request info if read_request_line() fails with

a timeout. In that case there's not yet any new useful request info
available.
Noticed via server-status for prefork showing request "NULL" after
keep-alive connections timed out.

PR: 59333.
Backports: 1742792
Submitted by: rjung
Reviewed by: ylavic, wrowe

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1743516 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/STATUS b/STATUS
index 0da59d96d2f6a93634004a855ce31567fe701a4e..0035d34ee7726ed16af7da5664a14fb1d013bb06 100644 (file)
--- a/STATUS
+++ b/STATUS
@@ -114,20 +114,6 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
-   * Don't globber scoreboard request info if read_request_line() fails with
-     a timeout. In that case there's not yet any new useful request info
-     available.
-     Noticed via server-status for prefork showing request "NULL" after
-     keep-alive connections timed out.
-     No CHANGES entry needed, because there's already one for PR 59333.
-     Sorry for the three patches. The first one is overwritten by the second
-     one, so technically only the second is needed, but merging both keeps
-     the mergeinfo more complete.
-     trunk patch: http://svn.apache.org/r1742791
-                  http://svn.apache.org/r1742792
-     2.4.x patch: trunk works
-     +1: rjung, ylavic, wrowe
-
 
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]

diff --git a/server/protocol.c b/server/protocol.c
index 817cd3e12676c88e648974729958323196060711..88d0f992517091e42f021f6b573a1a37528d1e48 100644 (file)
--- a/server/protocol.c
+++ b/server/protocol.c
@@ -992,7 +992,7 @@ request_rec *ap_read_request(conn_rec *conn)
             goto traceout;
         }
         else if (r->status == HTTP_REQUEST_TIME_OUT) {
-            ap_update_child_status(conn->sbh, SERVER_BUSY_LOG, r);
+            ap_update_child_status(conn->sbh, SERVER_BUSY_LOG, NULL);
             if (!r->connection->keepalives) {
                 ap_run_log_transaction(r);
             }