]> granicus.if.org Git - sudo/commitdiff
Cast isalnum() arg to unsigned char.
authorTodd C. Miller <Todd.Miller@courtesan.com>
Wed, 16 Jun 2010 19:28:45 +0000 (15:28 -0400)
committerTodd C. Miller <Todd.Miller@courtesan.com>
Wed, 16 Jun 2010 19:28:45 +0000 (15:28 -0400)
--HG--
branch : 1.7

sudo.c

diff --git a/sudo.c b/sudo.c
index bf44a3e52bb13f09d0c54c81032df32619585240..b384d567ce11f3835a3660c9a9b353607290742f 100644 (file)
--- a/sudo.c
+++ b/sudo.c
@@ -708,10 +708,9 @@ init_vars(sudo_mode, envp)
 
        av[0] = user_shell;     /* may be updated later */
        if (NewArgc > 0) {
-           size_t cmnd_size;
+           size_t cmnd_size = 1024;
            char *cmnd, *src, *dst, **ap;
 
-           cmnd_size = 1024;
            cmnd = dst = emalloc(cmnd_size);
            for (ap = NewArgv; *ap != NULL; ap++) {
                for (src = *ap; *src != '\0'; src++) {
@@ -723,7 +722,7 @@ init_vars(sudo_mode, envp)
                        dst = new_cmnd + (dst - cmnd);
                        cmnd = new_cmnd;
                    }
-                   if (isalnum(*src) || *src == '_' || *src == '-') {
+                   if (isalnum((unsigned char)*src) || *src == '_' || *src == '-') {
                        *dst++ = *src;
                    } else {
                        /* quote potential meta character */