]> granicus.if.org Git - python/commitdiff
Issue #18644: Fix a ResourceWarning in formatter.test().
authorBerker Peksag <berker.peksag@gmail.com>
Mon, 5 Jan 2015 07:19:40 +0000 (09:19 +0200)
committerBerker Peksag <berker.peksag@gmail.com>
Mon, 5 Jan 2015 07:19:40 +0000 (09:19 +0200)
Patch by Vajrasky Kok.

Lib/formatter.py

index d8cca52e307feafaef3178c0d8c582ae8be91c9d..9338261be7c749abb701ad9e92ecce0b61040af8 100644 (file)
@@ -436,11 +436,15 @@ def test(file = None):
         fp = open(sys.argv[1])
     else:
         fp = sys.stdin
-    for line in fp:
-        if line == '\n':
-            f.end_paragraph(1)
-        else:
-            f.add_flowing_data(line)
+    try:
+        for line in fp:
+            if line == '\n':
+                f.end_paragraph(1)
+            else:
+                f.add_flowing_data(line)
+    finally:
+        if fp is not sys.stdin:
+            fp.close()
     f.end_paragraph(0)