Remove unnecessary strcmp for mutt_view_attachment()

mutt_rfc1524_expand_filename() runs the result through
mutt_adv_mktemp(), which will sanitize and relocate the filename under
$tmpdir.  The strcmp() is unneeded and distracting to the program
logic; none of the other routines perform or need this check.

Co-authored-by: Richard Russon <rich@flatcap.org>

diff --git a/mutt_attach.c b/mutt_attach.c
index 66978ac5124f2ef8a5e43a7678a9becb13c10762..43d82392908560853f160c2abafc44f72ae2d9c4 100644 (file)
--- a/mutt_attach.c
+++ b/mutt_attach.c
@@ -458,7 +458,7 @@ int mutt_view_attachment(FILE *fp, struct Body *a, enum ViewAttachMode mode,
 
     if (mutt_rfc1524_expand_filename(entry->nametemplate, fname, tmpfile))
     {
-      if (!fp && (mutt_str_strcmp(mutt_b2s(tmpfile), a->filename) != 0))
+      if (!fp)
       {
         /* send case: the file is already there */
         if (mutt_file_symlink(a->filename, mutt_b2s(tmpfile)) == -1)