]> granicus.if.org Git - graphviz/commitdiff
xdot: MSBuild: define GVDLL to ensure correct storage-class attributes
authorMagnus Jacobsson <Magnus.Jacobsson@berotec.se>
Mon, 3 Jan 2022 06:20:54 +0000 (07:20 +0100)
committerMagnus Jacobsson <Magnus.Jacobsson@berotec.se>
Mon, 10 Jan 2022 14:09:12 +0000 (15:09 +0100)
An upcoming commit will change the storage-class attributes in
xdot.h to be controlled by the GVDLL symbol.

Without this change, errors like this would occur in lib/gvc:

LINK : fatal error LNK1104: cannot open file 'C:\Users\magja\graphviz\Debug\Graphviz\bin\xdot.lib'
Done building project "gvc.vcxproj" -- FAILED.

Towards https://gitlab.com/graphviz/graphviz/-/issues/2173.

lib/xdot/xdot.vcxproj

index bbb0f7138bc57b43b3c2c1e534d1a130571ecdf1..8cc985c3dd2f72a480a78a2a92c67a84072abb15 100644 (file)
@@ -52,7 +52,7 @@
     <ClCompile>
       <Optimization>Disabled</Optimization>
       <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)\lib;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PreprocessorDefinitions>EXPORT_XDOT;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>GVDLL;EXPORT_XDOT;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
       <RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
       <PrecompiledHeader />
@@ -70,7 +70,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
     <ClCompile>
       <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)\lib;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PreprocessorDefinitions>EXPORT_XDOT;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>GVDLL;EXPORT_XDOT;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <PrecompiledHeader />
       <WarningLevel>Level4</WarningLevel>
       <EnablePREfast>true</EnablePREfast>