]> granicus.if.org Git - psmisc/commitdiff
killall: fix potential string overflow [cppcheck]
authorSami Kerola <kerolasa@iki.fi>
Wed, 8 Feb 2012 21:35:32 +0000 (22:35 +0100)
committerCraig Small <csmall@users.sourceforge.net>
Thu, 9 Feb 2012 20:06:05 +0000 (07:06 +1100)
[src/killall.c:138]: (warning) scanf without field width limits can crash with huge input data

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
src/killall.c

index 656a335282dc648949fb1cc5abb4f26e46fe0eec..f108c778c55ea7a89e27e7949a7a9a7ea2785912 100644 (file)
@@ -135,7 +135,7 @@ uptime()
    }
    savelocale = setlocale(LC_NUMERIC, NULL);
    setlocale(LC_NUMERIC,"C");
-   if (fscanf(file, "%s", buf) == EOF) perror("uptime");
+   if (fscanf(file, "%2047s", buf) == EOF) perror("uptime");
    fclose(file);
    setlocale(LC_NUMERIC,savelocale);
    return atof(buf);