]> granicus.if.org Git - graphviz/commitdiff
Remove 9 -Wsign-conversion warnings in _DTCMP
authorMagnus Jacobsson <magnus.jacobsson@berotec.se>
Thu, 27 Aug 2020 14:47:35 +0000 (16:47 +0200)
committerMagnus Jacobsson <magnus.jacobsson@berotec.se>
Mon, 7 Sep 2020 13:42:17 +0000 (15:42 +0200)
Casting to size_t is safe since sz is always positive when it happens.

lib/cdt/cdt.h

index ffa2c1979a87f7f4d1e14917829291bb592a4270..7bafbc061c4212df7bf5ec2b253315088698bbed 100644 (file)
@@ -210,7 +210,7 @@ CDT_API unsigned int        dtstrhash(unsigned int, void*, int);
 
 #define _DTCMP(dt,k1,k2,dc,cmpf,sz) \
                        (cmpf ? (*cmpf)(dt,k1,k2,dc) : \
-                        (sz <= 0 ? strcmp(k1,k2) : memcmp(k1,k2,sz)) )
+                        (sz <= 0 ? strcmp(k1,k2) : memcmp(k1,k2,(size_t)sz)) )
 #define _DTHSH(dt,ky,dc,sz) (dc->hashf ? (*dc->hashf)(dt,ky,dc) : dtstrhash(0,ky,sz) )
 
 /* special search function for tree structure only */