pathpath: replace PATH_EXECUTE pathexists call with X_OK access call

This is equivalent and relies solely on standard library functionality. This
effectively inlines and simplifies the call to pathexists that previously
existed. The caching pathexists does is no longer relevant. An improved version
of this is provided by a modern operating system’s buffer cache.

diff --git a/lib/ast/pathpath.c b/lib/ast/pathpath.c
index b3790a871e252e1f2b8abd70c3671d2aa9027703..10cc57812fbb230eb85205f69dfc6428715ab91d 100644 (file)
--- a/lib/ast/pathpath.c
+++ b/lib/ast/pathpath.c
@@ -95,7 +95,7 @@ char *pathpath(char *path, const char *p)
                            goto normal;
                    while (*--s != '/');
                    strcpy(s + 1, "bin");
-                   if (pathexists(path, PATH_EXECUTE)) {
+                   if (access(path, X_OK) == 0) {
                        if ((s = pathaccess(path, path, p, a, PATH_REGULAR)))
                            return path == buf ? strdup(s) : s;
                        goto normal;