removed the function for domxml_node_add_child and made an alias to

domxml_node_append_child for BC

diff --git a/ext/domxml/php_domxml.c b/ext/domxml/php_domxml.c
index 20b6d0b12da6a903276a41d489f903e80a89e2f1..bdbfdf223cafc325befc2253433539c1ed5ab0f4 100644 (file)
--- a/ext/domxml/php_domxml.c
+++ b/ext/domxml/php_domxml.c
@@ -344,7 +344,7 @@ static zend_function_entry php_domxmlnode_class_functions[] = {
        PHP_FALIAS(prefix,                                      domxml_node_prefix,                             NULL)
        PHP_FALIAS(clone_node,                          domxml_clone_node,                              NULL)
 /* Non DOM functions start here */
-       PHP_FALIAS(add_child,                           domxml_node_add_child,                  NULL)
+       PHP_FALIAS(add_child,                           domxml_node_append_child,               NULL)
        PHP_FALIAS(append_sibling,                      domxml_node_append_sibling,             NULL)
        PHP_FALIAS(node,                                        domxml_node,                                    NULL)
        PHP_FALIAS(unlink,                                      domxml_node_unlink_node,                NULL)
@@ -1968,43 +1968,6 @@ PHP_FUNCTION(domxml_node_unlink_node)
 }
 /* }}} */
 
-/* {{{ proto object domxml_node_add_child(object domnode)
-   Adds existing node to parent node */
-PHP_FUNCTION(domxml_node_add_child)
-{
-       zval *id, *rv, *node;
-       xmlNodePtr child, nodep, new_child;
-       int ret;
-
-       DOMXML_GET_THIS_OBJ(nodep, id, le_domxmlnodep);
-
-       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "o", &node) == FAILURE) {
-               return;
-       }
-
-       DOMXML_GET_OBJ(child, node, le_domxmlnodep);
-
-       if (child->type == XML_ATTRIBUTE_NODE) {
-               php_error(E_WARNING, "%s(): can't add attribute node", get_active_function_name(TSRMLS_C));
-               RETURN_FALSE;
-       }
-
-       if (NULL == (new_child = xmlCopyNode(child, 1))) {
-               php_error(E_WARNING, "%s(): unable to clone node", get_active_function_name(TSRMLS_C));
-               RETURN_FALSE;
-       }
-
-       child = xmlAddChild(nodep, new_child);
-
-       if (NULL == child) {
-               php_error(E_WARNING, "%s(): couldn't add child", get_active_function_name(TSRMLS_C));
-               RETURN_FALSE;
-       }
-
-       DOMXML_RET_OBJ(rv, child, &ret);
-}
-/* }}} */
-
 /* {{{ proto object domxml_node_replace_node(object domnode)
    Replaces one node with another node */
 PHP_FUNCTION(domxml_node_replace_node)

diff --git a/ext/domxml/php_domxml.h b/ext/domxml/php_domxml.h
index 9e0fc170f2e1e78973deb153af7fc644c985a286..04c1de62c2d8674ab33f4c8bd307bd61133de5b6 100644 (file)
--- a/ext/domxml/php_domxml.h
+++ b/ext/domxml/php_domxml.h
@@ -113,7 +113,6 @@ PHP_FUNCTION(domxml_node_append_sibling);
 PHP_FUNCTION(domxml_node_append_child);
 PHP_FUNCTION(domxml_node_remove_child);
 PHP_FUNCTION(domxml_node_replace_child);
-PHP_FUNCTION(domxml_node_add_child);
 PHP_FUNCTION(domxml_node_has_attributes);
 PHP_FUNCTION(domxml_node_has_child_nodes);
 PHP_FUNCTION(domxml_node_parent);