Issue #23207: Improved kwarg validation.

diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
index 9a8685b3d42d1ef9979648082809bd744966c29a..e866b9623eb71c327b08dbf6503a25773fbb7e20 100644 (file)
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -1734,8 +1734,8 @@ def basicConfig(**kwargs):
                                      "specified together with 'handlers'")
             if handlers is None:
                 filename = kwargs.pop("filename", None)
+                mode = kwargs.pop("filemode", 'a')
                 if filename:
-                    mode = kwargs.pop("filemode", 'a')
                     h = FileHandler(filename, mode)
                 else:
                     stream = kwargs.pop("stream", None)

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 54be2176a81acb4f7b2a909a90920f8c425e1a66..8770e1b76c594d45f51b96eb0f1b20df585577a5 100644 (file)
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -3589,6 +3589,10 @@ class BasicConfigTest(unittest.TestCase):
                                                      handlers=handlers)
         assertRaises(ValueError, logging.basicConfig, stream=stream,
                                                      handlers=handlers)
+        # Issue 23207: test for invalid kwargs
+        assertRaises(ValueError, logging.basicConfig, loglevel=logging.INFO)
+        # Should pop both filename and filemode even if filename is None
+        logging.basicConfig(filename=None, filemode='a')
 
     def test_handlers(self):
         handlers = [