]> granicus.if.org Git - zfs/commitdiff
OpenZFS 6999 - fix 'Use of uninitialized value $picky in numeric eq (==)' in cstyle
authorGiuseppe Di Natale <dinatale2@users.noreply.github.com>
Thu, 26 Jan 2017 20:36:56 +0000 (12:36 -0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 26 Jan 2017 20:36:56 +0000 (12:36 -0800)
Authored by: Richard PALO <richard@NetBSD.org>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Approved by: Robert Mustacchi <rm@joyent.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported-by: Giuseppe Di Natale <dinatale2@llnl.gov>
OpenZFS-issue: https://www.illumos.org/issues/6999
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/002ec3e
Closes #5653

scripts/cstyle.pl

index 7b0c9b7e78699cfb7c1224aae397599092d64a83..f8dac9c2d94014ed023a4c1d994d9f845def19c7 100755 (executable)
@@ -440,7 +440,7 @@ line: while (<$filehandle>) {
                $function_header_full_indent = 0;
        }
        if ($in_function_header && /{$/ ) {
-               if ($picky == 1) {
+               if ($picky) {
                        err("opening brace on same line as function header");
                }
                $in_function_header = 0;