]> granicus.if.org Git - ipset/commitdiff
netfilter: ipset: make ip_set_get_ip*_port to use skb_network_offset
authorAlexander Drozdov <al.drozdov@gmail.com>
Fri, 6 Mar 2015 10:44:06 +0000 (13:44 +0300)
committerJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Wed, 11 Mar 2015 16:20:46 +0000 (17:20 +0100)
All the ipset functions respect skb->network_header value,
except for ip_set_get_ip4_port() & ip_set_get_ip6_port(). The
functions should use skb_network_offset() to get the transport
header offset.

Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
kernel/net/netfilter/ipset/ip_set_getport.c

index 4d9a2c037ae906f79a8ffa1162686da3ffd7062a..267144abef56c5c40a16dfcc101f5dd7933f6774 100644 (file)
@@ -102,7 +102,7 @@ ip_set_get_ip4_port(const struct sk_buff *skb, bool src,
                    __be16 *port, u8 *proto)
 {
        const struct iphdr *iph = ip_hdr(skb);
-       unsigned int protooff = ip_hdrlen(skb);
+       unsigned int protooff = skb_network_offset(skb) + ip_hdrlen(skb);
        int protocol = iph->protocol;
 
        /* See comments at tcp_match in ip_tables.c */
@@ -140,7 +140,9 @@ ip_set_get_ip6_port(const struct sk_buff *skb, bool src,
        __be16 frag_off = 0;
 
        nexthdr = ipv6_hdr(skb)->nexthdr;
-       protoff = ipv6_skip_exthdr(skb, sizeof(struct ipv6hdr), &nexthdr,
+       protoff = ipv6_skip_exthdr(skb,
+                                  skb_network_offset(skb) +
+                                       sizeof(struct ipv6hdr), &nexthdr,
                                   &frag_off);
        if (protoff < 0 || (frag_off & htons(~0x7)) != 0)
                return false;