Fix session-lifespan memory leak when a plperl function is redefined:

we have to tell Perl it can release its compiled copy of the function
text.  Noted by Alexey Klyukin.

Back-patch to 8.2 --- the problem exists further back, but this patch
won't work without modification, and it's probably not worth the trouble.

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index 0954098dfafbddcad06853aa0e80607283f18f90..4fed6ee8b5197a714b1f96f7aa6e5807617940d1 100644 (file)
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plperl.c - perl as a procedural language for PostgreSQL
  *
- *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.123.2.8 2009/10/31 18:12:20 tgl Exp $
+ *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.123.2.9 2009/11/29 21:02:34 tgl Exp $
  *
  **********************************************************************/
 
@@ -1502,10 +1502,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
 
                if (!uptodate)
                {
-                       free(prodesc); /* are we leaking memory here? */
-                       prodesc = NULL;
                        hash_search(plperl_proc_hash, internal_proname,
-                                               HASH_REMOVE,NULL);
+                                               HASH_REMOVE, NULL);
+                       if (prodesc->reference)
+                               SvREFCNT_dec(prodesc->reference);
+                       free(prodesc->proname);
+                       free(prodesc);
+                       prodesc = NULL;
                }
        }