add -Wstrict-aliasing and remove bogus evtag_test from event.h

svn:r602

diff --git a/ChangeLog b/ChangeLog
index 38b8c9da96778016e2095e6f234ae9825e2077a8..b18920d8f93f077db0793cb0130d852df9358549 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -27,7 +27,7 @@ Changes in current version:
  o fix a bug with event_rpcgen for integers
  o restructure the code to make event activation independent of regular event logic
  o Correctly handle DNS replies with no answers set (Fixes bug 1846282)
-
+ o add -Wstrict-aliasing to warnings and more cleanup
 
 Changes in 1.4.0:
  o allow \r or \n individually to separate HTTP headers instead of the standard "\r\n"; from Charles Kerr.

diff --git a/configure.in b/configure.in
index ea8dd114baea243f7e640ee372625c07a25aad53..dae19af93b292d8c0025205bfc3195281574a94b 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -353,7 +353,7 @@ if test x$enable_gcc_warnings = xyes; then
 #endif]), have_gcc42=yes, have_gcc42=no)
 
   CFLAGS="$CFLAGS -W -Wfloat-equal -Wundef -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wmissing-declarations -Wredundant-decls -Wnested-externs -Wbad-function-cast -Wswitch-enum -Werror"
-  CFLAGS="$CFLAGS -Wno-unused-parameter -Wno-sign-compare"
+  CFLAGS="$CFLAGS -Wno-unused-parameter -Wno-sign-compare -Wstrict-aliasing"
 
   if test x$have_gcc4 = xyes ; then 
     # These warnings break gcc 3.3.5 and work on gcc 4.0.2

diff --git a/event.h b/event.h
index c0bd8aca84ef78e9e2ca6e5d4d63021db6ed14e9..9e5c4eaac9a4dd986573c637a821ea9ac4dcb767 100644 (file)
--- a/event.h
+++ b/event.h
@@ -1137,8 +1137,6 @@ void evtag_marshal_string(struct evbuffer *buf, ev_uint32_t tag,
 void evtag_marshal_timeval(struct evbuffer *evbuf, ev_uint32_t tag,
     struct timeval *tv);
 
-void evtag_test(void);
-
 int evtag_unmarshal(struct evbuffer *src, ev_uint32_t *ptag,
     struct evbuffer *dst);
 int evtag_peek(struct evbuffer *evbuf, ev_uint32_t *ptag);

diff --git a/test/regress.c b/test/regress.c
index 993fd8a03bf61501b5eea6226248e8a3cc52dcc4..aa17c0149a85d73336704ab59bda0eb367e6a82e 100644 (file)
--- a/test/regress.c
+++ b/test/regress.c
@@ -1377,7 +1377,7 @@ evtag_tag_encoding(void)
        fprintf(stdout, "\t%s: OK\n", __func__);
 }
 
-void
+static void
 evtag_test(void)
 {
        fprintf(stdout, "Testing Tagging:\n");