- Fixed ReflectionClass::getStaticProperties() to do not return the private propertie...

  behavior already adopted in ReflectionClass::getDefaultProperties() and ReflectionClass::getProperties().

diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index 8f3e6be392b0bb462bac66cf076f49c511b639b3..4f82b309a19f1844f292c61092068108414840c5 100644 (file)
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -3216,13 +3216,16 @@ ZEND_METHOD(reflection_class, getStaticProperties)
                        zend_u_unmangle_property_name(IS_UNICODE, key, key_len-1, &class_name, &prop_name);
                        prop_name_len = u_strlen(prop_name.u);
 
-                       /* copy: enforce read only access */
-                       ALLOC_ZVAL(prop_copy);
-                       *prop_copy = **value;
-                       zval_copy_ctor(prop_copy);
-                       INIT_PZVAL(prop_copy);
+                       /* filter privates from base classes */
+                       if (!(class_name.s && class_name.s[0] != '*' && u_strcmp(class_name.u, ce->name.u))) {                          
+                               /* copy: enforce read only access */
+                               ALLOC_ZVAL(prop_copy);
+                               *prop_copy = **value;
+                               zval_copy_ctor(prop_copy);
+                               INIT_PZVAL(prop_copy);
 
-                       add_u_assoc_zval(return_value, IS_UNICODE, prop_name, prop_copy);
+                               add_u_assoc_zval(return_value, IS_UNICODE, prop_name, prop_copy);
+                       }
                }
                zend_hash_move_forward_ex(CE_STATIC_MEMBERS(ce), &pos);
        }

diff --git a/ext/reflection/tests/ReflectionClass_getDefaultProperties_001.phpt b/ext/reflection/tests/ReflectionClass_getDefaultProperties_001.phpt
index 3bf8f77ec69b9f679c001ef9cac9cfce7122c850..e19db811881a5732cdb28c8f5d576464c7003799 100644 (file)
--- a/ext/reflection/tests/ReflectionClass_getDefaultProperties_001.phpt
+++ b/ext/reflection/tests/ReflectionClass_getDefaultProperties_001.phpt
@@ -109,13 +109,12 @@ Array
 (
     [statPubC] => stat pubC in B
     [statProtC] => stat protC in B
-    [statPrivC] => stat privC in A
+    [statPrivC] => stat privC in B
     [statPubB] => stat pubB in B
     [statProtB] => stat protB in B
     [statPrivB] => stat privB in B
     [statPubA] => stat pubA in A
     [statProtA] => stat protA in A
-    [statPrivA] => stat privA in A
 )
 
 
@@ -146,13 +145,11 @@ Array
 (
     [statPubC] => stat pubC in C
     [statProtC] => stat protC in C
-    [statPrivC] => stat privC in A
+    [statPrivC] => stat privC in C
     [statPubB] => stat pubB in B
     [statProtB] => stat protB in B
-    [statPrivB] => stat privB in B
     [statPubA] => stat pubA in A
     [statProtA] => stat protA in A
-    [statPrivA] => stat privA in A
 )
 
 
@@ -195,4 +192,3 @@ Array
     [protC] => protC in X
     [privC] => privC in X
 )
-

diff --git a/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001.phpt b/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001.phpt
index 70a3bab9c258e2f34ad7b837be0148199b08294e..082ef676cd0ba0d0a8a0f008a97ce2cdde643eb8 100644 (file)
--- a/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001.phpt
+++ b/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001.phpt
@@ -67,11 +67,11 @@ Array
 )
 Array
 (
-    [privateOverridden] => new value 4
+    [privateOverridden] => new value 5
     [protectedOverridden] => new value 6
     [publicOverridden] => new value 7
 )
 
 Set non-existent values from A with no default value:
 Class A does not have a property named protectedOverridden
-Class A does not have a property named privateOverridden
\ No newline at end of file
+Class A does not have a property named privateOverridden

diff --git a/ext/reflection/tests/bug49074.phpt b/ext/reflection/tests/bug49074.phpt
index b8990a3db90829591ab9b4c4618120fe6b118f90..0bf94aaabf13d480283c01e588104a147d8e4b13 100644 (file)
--- a/ext/reflection/tests/bug49074.phpt
+++ b/ext/reflection/tests/bug49074.phpt
@@ -23,13 +23,9 @@ $m['data4'] = 400;
 var_dump($r->getStaticProperties());
 ?>
 --EXPECT--
-array(4) {
+array(2) {
   [u"data2"]=>
   int(2)
   [u"data3"]=>
   int(3)
-  [u"data1"]=>
-  int(1)
-  [u"data4"]=>
-  int(4)
 }