]> granicus.if.org Git - python/commitdiff
Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
authorSerhiy Storchaka <storchaka@gmail.com>
Mon, 25 Apr 2016 05:59:35 +0000 (08:59 +0300)
committerSerhiy Storchaka <storchaka@gmail.com>
Mon, 25 Apr 2016 05:59:35 +0000 (08:59 +0300)
differing items.  This affects assertListEqual() and assertTupleEqual().

Lib/unittest/case.py
Misc/NEWS

index 644fe5b5c5a8e37fa12f4db54f1145436cfe3bf9..0c23c96595ede4c696ec642ffdb2b05fc48f8b59 100644 (file)
@@ -689,7 +689,7 @@ class TestCase(object):
 
                 if item1 != item2:
                     differing += ('\nFirst differing element %d:\n%s\n%s\n' %
-                                 (i, item1, item2))
+                                 (i, safe_repr(item1), safe_repr(item2)))
                     break
             else:
                 if (len1 == len2 and seq_type is None and
@@ -702,7 +702,7 @@ class TestCase(object):
                              'elements.\n' % (seq_type_name, len1 - len2))
                 try:
                     differing += ('First extra element %d:\n%s\n' %
-                                  (len2, seq1[len2]))
+                                  (len2, safe_repr(seq1[len2])))
                 except (TypeError, IndexError, NotImplementedError):
                     differing += ('Unable to index element %d '
                                   'of first %s\n' % (len2, seq_type_name))
@@ -711,7 +711,7 @@ class TestCase(object):
                              'elements.\n' % (seq_type_name, len2 - len1))
                 try:
                     differing += ('First extra element %d:\n%s\n' %
-                                  (len1, seq2[len1]))
+                                  (len1, safe_repr(seq2[len1])))
                 except (TypeError, IndexError, NotImplementedError):
                     differing += ('Unable to index element %d '
                                   'of second %s\n' % (len1, seq_type_name))
index 54cd13866b3ddf273f211c38d61564501ed47a50..6380bf964eb42cf69c7e650c5d089b1c6bbb6927 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -77,6 +77,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
+  differing items.  This affects assertListEqual() and assertTupleEqual().
+
 - Issue #26822: itemgetter, attrgetter and methodcaller objects no longer
   silently ignore keyword arguments.