]> granicus.if.org Git - postgresql/commitdiff
Have TRUNCATE update pgstat tuple counters
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 20 Feb 2015 15:10:01 +0000 (12:10 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 20 Feb 2015 15:10:01 +0000 (12:10 -0300)
This works by keeping a per-subtransaction record of the ins/upd/del
counters before the truncate, and then resetting them; this record is
useful to return to the previous state in case the truncate is rolled
back, either in a subtransaction or whole transaction.  The state is
propagated upwards as subtransactions commit.

When the per-table data is sent to the stats collector, a flag indicates
to reset the live/dead counters to zero as well.

Catalog version bumped due to the change in pgstat format.

Author: Alexander Shulgin
Discussion: 1007.1207238291@sss.pgh.pa.us
Discussion: 548F7D38.2000401@BlueTreble.com
Reviewed-by: Álvaro Herrera, Jim Nasby
src/backend/commands/tablecmds.c
src/backend/postmaster/pgstat.c
src/include/pgstat.h
src/test/regress/expected/prepared_xacts.out
src/test/regress/expected/prepared_xacts_1.out
src/test/regress/expected/stats.out
src/test/regress/sql/prepared_xacts.sql
src/test/regress/sql/stats.sql

index 66d5083e4aa2832b682a1af602c73eaae650d464..b2993b80fbc255aecf0ff4039ff89f9b65e4a7e4 100644 (file)
@@ -71,6 +71,7 @@
 #include "parser/parse_type.h"
 #include "parser/parse_utilcmd.h"
 #include "parser/parser.h"
+#include "pgstat.h"
 #include "rewrite/rewriteDefine.h"
 #include "rewrite/rewriteHandler.h"
 #include "rewrite/rewriteManip.h"
@@ -1220,6 +1221,8 @@ ExecuteTruncate(TruncateStmt *stmt)
                         */
                        reindex_relation(heap_relid, REINDEX_REL_PROCESS_TOAST);
                }
+
+               pgstat_count_truncate(rel);
        }
 
        /*
index 268bcd58fd8d7da3091f46a6760240a5b2876781..1148e29090d113ffc64dd52cafe1dd3297160fe7 100644 (file)
@@ -197,8 +197,12 @@ typedef struct TwoPhasePgStatRecord
        PgStat_Counter tuples_inserted;         /* tuples inserted in xact */
        PgStat_Counter tuples_updated;          /* tuples updated in xact */
        PgStat_Counter tuples_deleted;          /* tuples deleted in xact */
+       PgStat_Counter inserted_pre_trunc;      /* tuples inserted prior to truncate */
+       PgStat_Counter updated_pre_trunc;       /* tuples updated prior to truncate */
+       PgStat_Counter deleted_pre_trunc;       /* tuples deleted prior to truncate */
        Oid                     t_id;                   /* table's OID */
        bool            t_shared;               /* is it a shared catalog? */
+       bool            t_truncated;    /* was the relation truncated? */
 } TwoPhasePgStatRecord;
 
 /*
@@ -1858,6 +1862,64 @@ pgstat_count_heap_delete(Relation rel)
        }
 }
 
+/*
+ * pgstat_truncate_save_counters
+ *
+ * Whenever a table is truncated, we save its i/u/d counters so that they can
+ * be cleared, and if the (sub)xact that executed the truncate later aborts,
+ * the counters can be restored to the saved (pre-truncate) values.  Note we do
+ * this on the first truncate in any particular subxact level only.
+ */
+static void
+pgstat_truncate_save_counters(PgStat_TableXactStatus *trans)
+{
+       if (!trans->truncated)
+       {
+               trans->inserted_pre_trunc = trans->tuples_inserted;
+               trans->updated_pre_trunc = trans->tuples_updated;
+               trans->deleted_pre_trunc = trans->tuples_deleted;
+               trans->truncated = true;
+       }
+}
+
+/*
+ * pgstat_truncate_restore_counters - restore counters when a truncate aborts
+ */
+static void
+pgstat_truncate_restore_counters(PgStat_TableXactStatus *trans)
+{
+       if (trans->truncated)
+       {
+               trans->tuples_inserted = trans->inserted_pre_trunc;
+               trans->tuples_updated = trans->updated_pre_trunc;
+               trans->tuples_deleted = trans->deleted_pre_trunc;
+       }
+}
+
+/*
+ * pgstat_count_truncate - update tuple counters due to truncate
+ */
+void
+pgstat_count_truncate(Relation rel)
+{
+       PgStat_TableStatus *pgstat_info = rel->pgstat_info;
+
+       if (pgstat_info != NULL)
+       {
+               /* We have to log the effect at the proper transactional level */
+               int                     nest_level = GetCurrentTransactionNestLevel();
+
+               if (pgstat_info->trans == NULL ||
+                       pgstat_info->trans->nest_level != nest_level)
+                       add_tabstat_xact_level(pgstat_info, nest_level);
+
+               pgstat_truncate_save_counters(pgstat_info->trans);
+               pgstat_info->trans->tuples_inserted = 0;
+               pgstat_info->trans->tuples_updated = 0;
+               pgstat_info->trans->tuples_deleted = 0;
+       }
+}
+
 /*
  * pgstat_update_heap_dead_tuples - update dead-tuples count
  *
@@ -1916,12 +1978,22 @@ AtEOXact_PgStat(bool isCommit)
                        Assert(trans->upper == NULL);
                        tabstat = trans->parent;
                        Assert(tabstat->trans == trans);
+                       /* restore pre-truncate stats (if any) in case of aborted xact */
+                       if (!isCommit)
+                               pgstat_truncate_restore_counters(trans);
                        /* count attempted actions regardless of commit/abort */
                        tabstat->t_counts.t_tuples_inserted += trans->tuples_inserted;
                        tabstat->t_counts.t_tuples_updated += trans->tuples_updated;
                        tabstat->t_counts.t_tuples_deleted += trans->tuples_deleted;
                        if (isCommit)
                        {
+                               tabstat->t_counts.t_truncated = trans->truncated;
+                               if (trans->truncated)
+                               {
+                                       /* forget live/dead stats seen by backend thus far */
+                                       tabstat->t_counts.t_delta_live_tuples = 0;
+                                       tabstat->t_counts.t_delta_dead_tuples = 0;
+                               }
                                /* insert adds a live tuple, delete removes one */
                                tabstat->t_counts.t_delta_live_tuples +=
                                        trans->tuples_inserted - trans->tuples_deleted;
@@ -1986,9 +2058,21 @@ AtEOSubXact_PgStat(bool isCommit, int nestDepth)
                        {
                                if (trans->upper && trans->upper->nest_level == nestDepth - 1)
                                {
-                                       trans->upper->tuples_inserted += trans->tuples_inserted;
-                                       trans->upper->tuples_updated += trans->tuples_updated;
-                                       trans->upper->tuples_deleted += trans->tuples_deleted;
+                                       if (trans->truncated)
+                                       {
+                                               /* propagate the truncate status one level up */
+                                               pgstat_truncate_save_counters(trans->upper);
+                                               /* replace upper xact stats with ours */
+                                               trans->upper->tuples_inserted = trans->tuples_inserted;
+                                               trans->upper->tuples_updated = trans->tuples_updated;
+                                               trans->upper->tuples_deleted = trans->tuples_deleted;
+                                       }
+                                       else
+                                       {
+                                               trans->upper->tuples_inserted += trans->tuples_inserted;
+                                               trans->upper->tuples_updated += trans->tuples_updated;
+                                               trans->upper->tuples_deleted += trans->tuples_deleted;
+                                       }
                                        tabstat->trans = trans->upper;
                                        pfree(trans);
                                }
@@ -2017,6 +2101,8 @@ AtEOSubXact_PgStat(bool isCommit, int nestDepth)
                                 * subtransaction
                                 */
 
+                               /* first restore values obliterated by truncate */
+                               pgstat_truncate_restore_counters(trans);
                                /* count attempted actions regardless of commit/abort */
                                tabstat->t_counts.t_tuples_inserted += trans->tuples_inserted;
                                tabstat->t_counts.t_tuples_updated += trans->tuples_updated;
@@ -2065,8 +2151,12 @@ AtPrepare_PgStat(void)
                        record.tuples_inserted = trans->tuples_inserted;
                        record.tuples_updated = trans->tuples_updated;
                        record.tuples_deleted = trans->tuples_deleted;
+                       record.inserted_pre_trunc = trans->inserted_pre_trunc;
+                       record.updated_pre_trunc = trans->updated_pre_trunc;
+                       record.deleted_pre_trunc = trans->deleted_pre_trunc;
                        record.t_id = tabstat->t_id;
                        record.t_shared = tabstat->t_shared;
+                       record.t_truncated = trans->truncated;
 
                        RegisterTwoPhaseRecord(TWOPHASE_RM_PGSTAT_ID, 0,
                                                                   &record, sizeof(TwoPhasePgStatRecord));
@@ -2132,6 +2222,8 @@ pgstat_twophase_postcommit(TransactionId xid, uint16 info,
        pgstat_info->t_counts.t_tuples_inserted += rec->tuples_inserted;
        pgstat_info->t_counts.t_tuples_updated += rec->tuples_updated;
        pgstat_info->t_counts.t_tuples_deleted += rec->tuples_deleted;
+       pgstat_info->t_counts.t_truncated = rec->t_truncated;
+
        pgstat_info->t_counts.t_delta_live_tuples +=
                rec->tuples_inserted - rec->tuples_deleted;
        pgstat_info->t_counts.t_delta_dead_tuples +=
@@ -2158,6 +2250,12 @@ pgstat_twophase_postabort(TransactionId xid, uint16 info,
        pgstat_info = get_tabstat_entry(rec->t_id, rec->t_shared);
 
        /* Same math as in AtEOXact_PgStat, abort case */
+       if (rec->t_truncated)
+       {
+               rec->tuples_inserted = rec->inserted_pre_trunc;
+               rec->tuples_updated = rec->updated_pre_trunc;
+               rec->tuples_deleted = rec->deleted_pre_trunc;
+       }
        pgstat_info->t_counts.t_tuples_inserted += rec->tuples_inserted;
        pgstat_info->t_counts.t_tuples_updated += rec->tuples_updated;
        pgstat_info->t_counts.t_tuples_deleted += rec->tuples_deleted;
@@ -4658,6 +4756,12 @@ pgstat_recv_tabstat(PgStat_MsgTabstat *msg, int len)
                        tabentry->tuples_updated += tabmsg->t_counts.t_tuples_updated;
                        tabentry->tuples_deleted += tabmsg->t_counts.t_tuples_deleted;
                        tabentry->tuples_hot_updated += tabmsg->t_counts.t_tuples_hot_updated;
+                       /* If table was truncated, first reset the live/dead counters */
+                       if (tabmsg->t_counts.t_truncated)
+                       {
+                               tabentry->n_live_tuples = 0;
+                               tabentry->n_dead_tuples = 0;
+                       }
                        tabentry->n_live_tuples += tabmsg->t_counts.t_delta_live_tuples;
                        tabentry->n_dead_tuples += tabmsg->t_counts.t_delta_dead_tuples;
                        tabentry->changes_since_analyze += tabmsg->t_counts.t_changed_tuples;
index 416769a7850059bb0f439eccf3c95ec2be320a42..6356085785cb14a37505188bba346f926fbfa447 100644 (file)
@@ -104,6 +104,7 @@ typedef struct PgStat_TableCounts
        PgStat_Counter t_tuples_updated;
        PgStat_Counter t_tuples_deleted;
        PgStat_Counter t_tuples_hot_updated;
+       bool            t_truncated;
 
        PgStat_Counter t_delta_live_tuples;
        PgStat_Counter t_delta_dead_tuples;
@@ -165,6 +166,10 @@ typedef struct PgStat_TableXactStatus
        PgStat_Counter tuples_inserted;         /* tuples inserted in (sub)xact */
        PgStat_Counter tuples_updated;          /* tuples updated in (sub)xact */
        PgStat_Counter tuples_deleted;          /* tuples deleted in (sub)xact */
+       bool            truncated;              /* relation truncated in this (sub)xact */
+       PgStat_Counter inserted_pre_trunc;      /* tuples inserted prior to truncate */
+       PgStat_Counter updated_pre_trunc;       /* tuples updated prior to truncate */
+       PgStat_Counter deleted_pre_trunc;       /* tuples deleted prior to truncate */
        int                     nest_level;             /* subtransaction nest level */
        /* links to other structs for same relation: */
        struct PgStat_TableXactStatus *upper;           /* next higher subxact if any */
@@ -960,6 +965,7 @@ extern void pgstat_initstats(Relation rel);
 extern void pgstat_count_heap_insert(Relation rel, int n);
 extern void pgstat_count_heap_update(Relation rel, bool hot);
 extern void pgstat_count_heap_delete(Relation rel);
+extern void pgstat_count_truncate(Relation rel);
 extern void pgstat_update_heap_dead_tuples(Relation rel, int delta);
 
 extern void pgstat_init_function_usage(FunctionCallInfoData *fcinfo,
index c0b08649e8d8b4543e47384a2a2975f590151ec7..9dbf874b63e86dfd3056b7f0737f43e1197acb3f 100644 (file)
@@ -247,8 +247,58 @@ SELECT gid FROM pg_prepared_xacts;
 -----
 (0 rows)
 
+CREATE TABLE pxtest5 (a SERIAL);
+INSERT INTO pxtest5 DEFAULT VALUES;
+SELECT * FROM pxtest5;
+ a 
+---
+ 1
+(1 row)
+
+BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+  TRUNCATE pxtest5;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+PREPARE TRANSACTION 'trunc-and-pgstat';
+SELECT pg_sleep(0.5);
+ pg_sleep 
+----------
+(1 row)
+
+SELECT n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname='pxtest5';
+ n_tup_ins | n_tup_upd | n_tup_del | n_live_tup | n_dead_tup 
+-----------+-----------+-----------+------------+------------
+         1 |         0 |         0 |          1 |          0
+(1 row)
+
+COMMIT PREPARED 'trunc-and-pgstat';
+SELECT pg_sleep(0.5);
+ pg_sleep 
+----------
+(1 row)
+
+SELECT n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname='pxtest5';
+ n_tup_ins | n_tup_upd | n_tup_del | n_live_tup | n_dead_tup 
+-----------+-----------+-----------+------------+------------
+         2 |         0 |         0 |          1 |          0
+(1 row)
+
+SELECT * FROM pxtest5;
+ a 
+---
+ 4
+(1 row)
+
 -- Clean up
 DROP TABLE pxtest2;
 DROP TABLE pxtest3;  -- will still be there if prepared xacts are disabled
 ERROR:  table "pxtest3" does not exist
 DROP TABLE pxtest4;
+DROP TABLE pxtest5;
index 898f278c11ed8aab20ea1a6bc45a2fcabda04dbc..dfdd5eb0dc1952391348ed44892a17e0b29660a7 100644 (file)
@@ -249,9 +249,62 @@ SELECT gid FROM pg_prepared_xacts;
 -----
 (0 rows)
 
+CREATE TABLE pxtest5 (a SERIAL);
+INSERT INTO pxtest5 DEFAULT VALUES;
+SELECT * FROM pxtest5;
+ a 
+---
+ 1
+(1 row)
+
+BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+  TRUNCATE pxtest5;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+PREPARE TRANSACTION 'trunc-and-pgstat';
+ERROR:  prepared transactions are disabled
+HINT:  Set max_prepared_transactions to a nonzero value.
+SELECT pg_sleep(0.5);
+ pg_sleep 
+----------
+(1 row)
+
+SELECT n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname='pxtest5';
+ n_tup_ins | n_tup_upd | n_tup_del | n_live_tup | n_dead_tup 
+-----------+-----------+-----------+------------+------------
+         3 |         0 |         0 |          1 |          2
+(1 row)
+
+COMMIT PREPARED 'trunc-and-pgstat';
+ERROR:  prepared transaction with identifier "trunc-and-pgstat" does not exist
+SELECT pg_sleep(0.5);
+ pg_sleep 
+----------
+(1 row)
+
+SELECT n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname='pxtest5';
+ n_tup_ins | n_tup_upd | n_tup_del | n_live_tup | n_dead_tup 
+-----------+-----------+-----------+------------+------------
+         3 |         0 |         0 |          1 |          2
+(1 row)
+
+SELECT * FROM pxtest5;
+ a 
+---
+ 1
+(1 row)
+
 -- Clean up
 DROP TABLE pxtest2;
 ERROR:  table "pxtest2" does not exist
 DROP TABLE pxtest3;  -- will still be there if prepared xacts are disabled
 DROP TABLE pxtest4;
 ERROR:  table "pxtest4" does not exist
+DROP TABLE pxtest5;
index 86319718591975212473d909ae5a95f2b4e26ccf..f5be70fe7c4948941abe35a8d6b22f6df5ec1757 100644 (file)
@@ -62,6 +62,57 @@ begin
     extract(epoch from clock_timestamp() - start_time);
 end
 $$ language plpgsql;
+-- test effects of TRUNCATE on n_live_tup/n_dead_tup counters
+CREATE TABLE trunc_stats_test(id serial);
+CREATE TABLE trunc_stats_test1(id serial);
+CREATE TABLE trunc_stats_test2(id serial);
+CREATE TABLE trunc_stats_test3(id serial);
+CREATE TABLE trunc_stats_test4(id serial);
+-- check that n_live_tup is reset to 0 after truncate
+INSERT INTO trunc_stats_test DEFAULT VALUES;
+INSERT INTO trunc_stats_test DEFAULT VALUES;
+INSERT INTO trunc_stats_test DEFAULT VALUES;
+TRUNCATE trunc_stats_test;
+-- test involving a truncate in a transaction; 4 ins but only 1 live
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+UPDATE trunc_stats_test1 SET id = id + 10 WHERE id IN (1, 2);
+DELETE FROM trunc_stats_test1 WHERE id = 3;
+BEGIN;
+UPDATE trunc_stats_test1 SET id = id + 100;
+TRUNCATE trunc_stats_test1;
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+COMMIT;
+-- use a savepoint: 1 insert, 1 live
+BEGIN;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+SAVEPOINT p1;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+TRUNCATE trunc_stats_test2;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+RELEASE SAVEPOINT p1;
+COMMIT;
+-- rollback a savepoint: this should count 4 inserts and have 2
+-- live tuples after commit (and 2 dead ones due to aborted subxact)
+BEGIN;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+SAVEPOINT p1;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+TRUNCATE trunc_stats_test3;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+ROLLBACK TO SAVEPOINT p1;
+COMMIT;
+-- rollback a truncate: this should count 2 inserts and produce 2 dead tuples
+BEGIN;
+INSERT INTO trunc_stats_test4 DEFAULT VALUES;
+INSERT INTO trunc_stats_test4 DEFAULT VALUES;
+TRUNCATE trunc_stats_test4;
+INSERT INTO trunc_stats_test4 DEFAULT VALUES;
+ROLLBACK;
 -- do a seqscan
 SELECT count(*) FROM tenk2;
  count 
@@ -92,6 +143,18 @@ SELECT wait_for_stats();
 (1 row)
 
 -- check effects
+SELECT relname, n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname like 'trunc_stats_test%' order by relname;
+      relname      | n_tup_ins | n_tup_upd | n_tup_del | n_live_tup | n_dead_tup 
+-------------------+-----------+-----------+-----------+------------+------------
+ trunc_stats_test  |         3 |         0 |         0 |          0 |          0
+ trunc_stats_test1 |         4 |         2 |         1 |          1 |          0
+ trunc_stats_test2 |         1 |         0 |         0 |          1 |          0
+ trunc_stats_test3 |         4 |         0 |         0 |          2 |          2
+ trunc_stats_test4 |         2 |         0 |         0 |          0 |          2
+(5 rows)
+
 SELECT st.seq_scan >= pr.seq_scan + 1,
        st.seq_tup_read >= pr.seq_tup_read + cl.reltuples,
        st.idx_scan >= pr.idx_scan + 1,
@@ -119,4 +182,5 @@ FROM prevstats AS pr;
  t
 (1 row)
 
+DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4;
 -- End of Stats Test
index 7902152775c70751ff8ceaf67114559f5736ac04..56d5857ae9c2a5e991763aba286c8856fc79221c 100644 (file)
@@ -152,7 +152,34 @@ SELECT * FROM pxtest3;
 -- There should be no prepared transactions
 SELECT gid FROM pg_prepared_xacts;
 
+CREATE TABLE pxtest5 (a SERIAL);
+INSERT INTO pxtest5 DEFAULT VALUES;
+
+SELECT * FROM pxtest5;
+
+BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+  TRUNCATE pxtest5;
+  INSERT INTO pxtest5 DEFAULT VALUES;
+PREPARE TRANSACTION 'trunc-and-pgstat';
+
+SELECT pg_sleep(0.5);
+SELECT n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname='pxtest5';
+
+COMMIT PREPARED 'trunc-and-pgstat';
+
+SELECT pg_sleep(0.5);
+SELECT n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname='pxtest5';
+
+SELECT * FROM pxtest5;
+
 -- Clean up
 DROP TABLE pxtest2;
 DROP TABLE pxtest3;  -- will still be there if prepared xacts are disabled
 DROP TABLE pxtest4;
+DROP TABLE pxtest5;
index 161630083081493f3f45e09bbbe70236085af0bd..cd2d5927bc59cbfd80318ccd26567e2a4bb6e10b 100644 (file)
@@ -58,6 +58,64 @@ begin
 end
 $$ language plpgsql;
 
+-- test effects of TRUNCATE on n_live_tup/n_dead_tup counters
+CREATE TABLE trunc_stats_test(id serial);
+CREATE TABLE trunc_stats_test1(id serial);
+CREATE TABLE trunc_stats_test2(id serial);
+CREATE TABLE trunc_stats_test3(id serial);
+CREATE TABLE trunc_stats_test4(id serial);
+
+-- check that n_live_tup is reset to 0 after truncate
+INSERT INTO trunc_stats_test DEFAULT VALUES;
+INSERT INTO trunc_stats_test DEFAULT VALUES;
+INSERT INTO trunc_stats_test DEFAULT VALUES;
+TRUNCATE trunc_stats_test;
+
+-- test involving a truncate in a transaction; 4 ins but only 1 live
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+UPDATE trunc_stats_test1 SET id = id + 10 WHERE id IN (1, 2);
+DELETE FROM trunc_stats_test1 WHERE id = 3;
+
+BEGIN;
+UPDATE trunc_stats_test1 SET id = id + 100;
+TRUNCATE trunc_stats_test1;
+INSERT INTO trunc_stats_test1 DEFAULT VALUES;
+COMMIT;
+
+-- use a savepoint: 1 insert, 1 live
+BEGIN;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+SAVEPOINT p1;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+TRUNCATE trunc_stats_test2;
+INSERT INTO trunc_stats_test2 DEFAULT VALUES;
+RELEASE SAVEPOINT p1;
+COMMIT;
+
+-- rollback a savepoint: this should count 4 inserts and have 2
+-- live tuples after commit (and 2 dead ones due to aborted subxact)
+BEGIN;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+SAVEPOINT p1;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+TRUNCATE trunc_stats_test3;
+INSERT INTO trunc_stats_test3 DEFAULT VALUES;
+ROLLBACK TO SAVEPOINT p1;
+COMMIT;
+
+-- rollback a truncate: this should count 2 inserts and produce 2 dead tuples
+BEGIN;
+INSERT INTO trunc_stats_test4 DEFAULT VALUES;
+INSERT INTO trunc_stats_test4 DEFAULT VALUES;
+TRUNCATE trunc_stats_test4;
+INSERT INTO trunc_stats_test4 DEFAULT VALUES;
+ROLLBACK;
+
 -- do a seqscan
 SELECT count(*) FROM tenk2;
 -- do an indexscan
@@ -71,12 +129,17 @@ SELECT pg_sleep(1.0);
 SELECT wait_for_stats();
 
 -- check effects
+SELECT relname, n_tup_ins, n_tup_upd, n_tup_del, n_live_tup, n_dead_tup
+  FROM pg_stat_user_tables
+ WHERE relname like 'trunc_stats_test%' order by relname;
+
 SELECT st.seq_scan >= pr.seq_scan + 1,
        st.seq_tup_read >= pr.seq_tup_read + cl.reltuples,
        st.idx_scan >= pr.idx_scan + 1,
        st.idx_tup_fetch >= pr.idx_tup_fetch + 1
   FROM pg_stat_user_tables AS st, pg_class AS cl, prevstats AS pr
  WHERE st.relname='tenk2' AND cl.relname='tenk2';
+
 SELECT st.heap_blks_read + st.heap_blks_hit >= pr.heap_blks + cl.relpages,
        st.idx_blks_read + st.idx_blks_hit >= pr.idx_blks + 1
   FROM pg_statio_user_tables AS st, pg_class AS cl, prevstats AS pr
@@ -85,4 +148,5 @@ SELECT st.heap_blks_read + st.heap_blks_hit >= pr.heap_blks + cl.relpages,
 SELECT pr.snap_ts < pg_stat_get_snapshot_timestamp() as snapshot_newer
 FROM prevstats AS pr;
 
+DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4;
 -- End of Stats Test