]> granicus.if.org Git - python/commitdiff
bpo-30911: Add tests for bad boolean arguments for accelerated json (#2690)
authorSerhiy Storchaka <storchaka@gmail.com>
Thu, 13 Jul 2017 07:14:11 +0000 (10:14 +0300)
committerGitHub <noreply@github.com>
Thu, 13 Jul 2017 07:14:11 +0000 (10:14 +0300)
encoder and decoder.

Lib/test/test_json/test_speedups.py

index 109a2466c21bdbd43528f22205a7f5f250377fac..8d98ab5ae1c39862d6b67cfce1a3950b57d31efa 100644 (file)
@@ -1,6 +1,11 @@
 from test.test_json import CTest
 
 
+class BadBool:
+    def __bool__(self):
+        1/0
+
+
 class TestSpeedups(CTest):
     def test_scanstring(self):
         self.assertEqual(self.json.decoder.scanstring.__module__, "_json")
@@ -17,8 +22,25 @@ class TestDecode(CTest):
     def test_make_scanner(self):
         self.assertRaises(AttributeError, self.json.scanner.c_make_scanner, 1)
 
+    def test_bad_bool_args(self):
+        def test(value):
+            self.json.decoder.JSONDecoder(strict=BadBool()).decode(value)
+        self.assertRaises(ZeroDivisionError, test, '""')
+        self.assertRaises(ZeroDivisionError, test, '{}')
+
+
+class TestEncode(CTest):
     def test_make_encoder(self):
         self.assertRaises(TypeError, self.json.encoder.c_make_encoder,
             (True, False),
             b"\xCD\x7D\x3D\x4E\x12\x4C\xF9\x79\xD7\x52\xBA\x82\xF2\x27\x4A\x7D\xA0\xCA\x75",
             None)
+
+    def test_bad_bool_args(self):
+        def test(name):
+            self.json.encoder.JSONEncoder(**{name: BadBool()}).encode({'a': 1})
+        self.assertRaises(ZeroDivisionError, test, 'skipkeys')
+        self.assertRaises(ZeroDivisionError, test, 'ensure_ascii')
+        self.assertRaises(ZeroDivisionError, test, 'check_circular')
+        self.assertRaises(ZeroDivisionError, test, 'allow_nan')
+        self.assertRaises(ZeroDivisionError, test, 'sort_keys')