coverity: refactor only

Refactor code for clarity.

diff --git a/buffer.c b/buffer.c
index 665dc5aebf87c185386b27059b4d16fe3390b90a..d57895004c38a695bd81b7b6262d7ebc967d779c 100644 (file)
--- a/buffer.c
+++ b/buffer.c
@@ -119,14 +119,11 @@ static void mutt_buffer_add (BUFFER* buf, const char* s, size_t len)
   if (!buf || !s)
     return;
 
-  size_t offset;
-
-  if (buf->dptr + len + 1 > buf->data + buf->dsize)
+  if ((buf->dptr + len + 1) > (buf->data + buf->dsize))
   {
-    offset = buf->dptr - buf->data;
-    buf->dsize += len < 128 ? 128 : len + 1;
-    /* suppress compiler aliasing warning */
-    safe_realloc ((void**) (void*) &buf->data, buf->dsize);
+    size_t offset = buf->dptr - buf->data;
+    buf->dsize += (len < 128) ? 128 : len + 1;
+    safe_realloc (&buf->data, buf->dsize);
     buf->dptr = buf->data + offset;
   }
   if (!buf->dptr)