Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.

diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index 3453a1f7a6b2901ffa92692096123e3a5b2f84f8..397403f221c95baa69c198aa831af36a0d0e443f 100644 (file)
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench/pgbench.c
@@ -958,6 +958,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
        {
                if (!timer_exceeded)
                        fprintf(stderr, "%s: cannot read the result\n", argv[0]);
+               (void) pclose(fp);
                return false;
        }
        if (pclose(fp) < 0)