]> granicus.if.org Git - postgresql/commitdiff
Tidy up a few calls to smrgextend().
authorRobert Haas <rhaas@postgresql.org>
Thu, 19 Aug 2010 02:58:37 +0000 (02:58 +0000)
committerRobert Haas <rhaas@postgresql.org>
Thu, 19 Aug 2010 02:58:37 +0000 (02:58 +0000)
In the new API introduced by my patch to include the backend ID in
temprel filenames, the last argument to smrgextend() became skipFsync
rather than isTemp, but these calls didn't get the memo.  It's not
really a problem to pass rel->rd_istemp rather than just plain false,
because smgrextend() now automatically skips the fsync for temprels
anyway, but this seems cleaner and saves some minute number of cycles.

src/backend/access/hash/hashpage.c
src/backend/access/heap/visibilitymap.c
src/backend/storage/freespace/freespace.c

index 77b072c88011ac820c155e5619cc325fa4c3eccf..d7df3d23913ed6ea2006265f9b95b1c7cb07a825 100644 (file)
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.83 2010/02/26 02:00:33 momjian Exp $
+ *       $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.84 2010/08/19 02:58:37 rhaas Exp $
  *
  * NOTES
  *       Postgres hash pages look like ordinary relation pages.  The opaque
@@ -733,7 +733,7 @@ _hash_alloc_buckets(Relation rel, BlockNumber firstblock, uint32 nblocks)
        MemSet(zerobuf, 0, sizeof(zerobuf));
 
        RelationOpenSmgr(rel);
-       smgrextend(rel->rd_smgr, MAIN_FORKNUM, lastblock, zerobuf, rel->rd_istemp);
+       smgrextend(rel->rd_smgr, MAIN_FORKNUM, lastblock, zerobuf, false);
 
        return true;
 }
index 9bc65acae559c8891d9c61832f84a8637dd9cea6..3276b2b5c6282ec968584e6847700ea249843f48 100644 (file)
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/access/heap/visibilitymap.c,v 1.11 2010/08/13 20:10:50 rhaas Exp $
+ *       $PostgreSQL: pgsql/src/backend/access/heap/visibilitymap.c,v 1.12 2010/08/19 02:58:37 rhaas Exp $
  *
  * INTERFACE ROUTINES
  *             visibilitymap_clear - clear a bit in the visibility map
@@ -477,7 +477,7 @@ vm_extend(Relation rel, BlockNumber vm_nblocks)
        while (vm_nblocks_now < vm_nblocks)
        {
                smgrextend(rel->rd_smgr, VISIBILITYMAP_FORKNUM, vm_nblocks_now,
-                                  (char *) pg, rel->rd_istemp);
+                                  (char *) pg, false);
                vm_nblocks_now++;
        }
 
index 040dd3344cd461e4ca7b32ae6bf84245c13a4ce7..3f6d7a3e18c1417e9e7b7b0aa227777089886549 100644 (file)
@@ -8,7 +8,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/storage/freespace/freespace.c,v 1.78 2010/08/13 20:10:52 rhaas Exp $
+ *       $PostgreSQL: pgsql/src/backend/storage/freespace/freespace.c,v 1.79 2010/08/19 02:58:37 rhaas Exp $
  *
  *
  * NOTES:
@@ -588,7 +588,7 @@ fsm_extend(Relation rel, BlockNumber fsm_nblocks)
        while (fsm_nblocks_now < fsm_nblocks)
        {
                smgrextend(rel->rd_smgr, FSM_FORKNUM, fsm_nblocks_now,
-                                  (char *) pg, rel->rd_istemp);
+                                  (char *) pg, false);
                fsm_nblocks_now++;
        }