]> granicus.if.org Git - zfs/commitdiff
OpenZFS restructuring - libspl
authorMatthew Macy <mmacy@mattmacy.io>
Wed, 2 Oct 2019 17:39:48 +0000 (10:39 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 2 Oct 2019 17:39:48 +0000 (10:39 -0700)
Factor Linux specific pieces out of libspl.

Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes #9336

65 files changed:
cmd/mount_zfs/Makefile.am
cmd/raidz_test/Makefile.am
cmd/zdb/Makefile.am
cmd/zed/Makefile.am
cmd/zed/agents/zfs_mod.c
cmd/zfs/Makefile.am
cmd/zfs/zfs_main.c
cmd/zhack/Makefile.am
cmd/zinject/Makefile.am
cmd/zinject/translate.c
cmd/zpool/Makefile.am
cmd/zpool/os/linux/zpool_vdev_os.c
cmd/zpool/zpool_vdev.c
cmd/zstreamdump/Makefile.am
cmd/ztest/Makefile.am
cmd/zvol_id/Makefile.am
config/Rules.am
configure.ac
lib/libavl/Makefile.am
lib/libefi/Makefile.am
lib/libicp/Makefile.am
lib/libnvpair/Makefile.am
lib/libshare/Makefile.am
lib/libspl/Makefile.am
lib/libspl/asm-generic/Makefile.am
lib/libspl/include/Makefile.am
lib/libspl/include/devid.h [deleted file]
lib/libspl/include/os/Makefile.am [new file with mode: 0644]
lib/libspl/include/os/linux/Makefile.am [new file with mode: 0644]
lib/libspl/include/os/linux/sys/Makefile.am [new file with mode: 0644]
lib/libspl/include/os/linux/sys/byteorder.h [moved from lib/libspl/include/sys/byteorder.h with 100% similarity]
lib/libspl/include/os/linux/sys/file.h [moved from lib/libspl/include/sys/file.h with 100% similarity]
lib/libspl/include/os/linux/sys/mnttab.h [moved from lib/libspl/include/sys/mnttab.h with 94% similarity]
lib/libspl/include/os/linux/sys/mount.h [moved from lib/libspl/include/sys/mount.h with 100% similarity]
lib/libspl/include/os/linux/sys/param.h [moved from lib/libspl/include/sys/param.h with 100% similarity]
lib/libspl/include/os/linux/sys/stat.h [moved from lib/libspl/include/sys/stat.h with 100% similarity]
lib/libspl/include/os/linux/sys/sysmacros.h [moved from lib/libspl/include/sys/sysmacros.h with 100% similarity]
lib/libspl/include/os/linux/sys/uio.h [moved from lib/libspl/include/sys/uio.h with 95% similarity]
lib/libspl/include/sys/Makefile.am
lib/libspl/os/linux/getexecname.c [moved from lib/libspl/getexecname.c with 100% similarity]
lib/libspl/os/linux/gethostid.c [moved from lib/libspl/gethostid.c with 100% similarity]
lib/libspl/os/linux/getmntany.c [moved from lib/libspl/getmntany.c with 62% similarity]
lib/libtpool/Makefile.am
lib/libunicode/Makefile.am
lib/libuutil/Makefile.am
lib/libzfs/Makefile.am
lib/libzfs/libzfs_import.c
lib/libzfs/libzfs_pool.c
lib/libzfs/libzfs_util.c
lib/libzfs_core/Makefile.am
lib/libzpool/Makefile.am
lib/libzpool/kernel.c
lib/libzutil/Makefile.am
lib/libzutil/zutil_import.c
tests/zfs-tests/cmd/file_write/file_write.c
tests/zfs-tests/cmd/largest_file/largest_file.c
tests/zfs-tests/cmd/libzfs_input_check/Makefile.am
tests/zfs-tests/cmd/mkbusy/mkbusy.c
tests/zfs-tests/cmd/mkfile/mkfile.c
tests/zfs-tests/cmd/nvlist_to_lua/Makefile.am
tests/zfs-tests/tests/functional/checksum/edonr_test.c
tests/zfs-tests/tests/functional/checksum/sha2_test.c
tests/zfs-tests/tests/functional/checksum/skein_test.c
tests/zfs-tests/tests/functional/hkdf/Makefile.am
tests/zfs-tests/tests/functional/libzfs/Makefile.am

index 7adedd63b6e66a1eedc878209474c3386ef0585f..1ffeef7fe189dc7735e21516aa41a9652e0f0b47 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 #
 # Ignore the prefix for the mount helper.  It must be installed in /sbin/
 # because this path is hardcoded in the mount(8) for security reasons.
index a394a0dde3b2036ab0aa58ca5469bfee0cd2733e..c04d101b885b1e11de546d0b15aed314995367ee 100644 (file)
@@ -6,10 +6,6 @@ AM_CFLAGS += $(FRAME_LARGER_THAN)
 # Unconditionally enable ASSERTs
 AM_CPPFLAGS += -DDEBUG -UNDEBUG
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 bin_PROGRAMS = raidz_test
 
 raidz_test_SOURCES = \
index 1fa7ec651ba707d822ddf9e9405730b92a71e627..07c1d068b04b92fbe8c146364da6a55ed790c643 100644 (file)
@@ -3,10 +3,6 @@ include $(top_srcdir)/config/Rules.am
 # Unconditionally enable debugging for zdb
 AM_CPPFLAGS += -DDEBUG -UNDEBUG
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 sbin_PROGRAMS = zdb
 
 zdb_SOURCES = \
index fb479f9b5c799c3bc37692834ae71c150878a088..40c0834af0a26a8a7208c80251deb0aa5c954ceb 100644 (file)
@@ -1,10 +1,6 @@
-SUBDIRS = zed.d
-
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
+SUBDIRS = zed.d
 
 sbin_PROGRAMS = zed
 
index d980794d0a576a8caa89f338aad5bb80190ffa2c..959ed24cd2df7c6dbe62fc1766344c8cc647f0c1 100644 (file)
@@ -69,7 +69,6 @@
  */
 
 #include <ctype.h>
-#include <devid.h>
 #include <fcntl.h>
 #include <libnvpair.h>
 #include <libzfs.h>
index 8b6ddaa200100dd16d36487defc88b221a5e0af3..49ad6f21f55fca1a325fd94d17fd327aede50693 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 sbin_PROGRAMS = zfs
 
 zfs_SOURCES = \
index 62c5bcca44daf11d6b333b5464c7ddf400f61924..9597e2790756299514805d5ffb32242d70551751 100644 (file)
@@ -6969,18 +6969,6 @@ unshare_unmount_path(int op, char *path, int flags, boolean_t is_manual)
        const char *cmdname = (op == OP_SHARE) ? "unshare" : "unmount";
        ino_t path_inode;
 
-       /*
-        * Search for the path in /proc/self/mounts. Rather than looking for the
-        * specific path, which can be fooled by non-standard paths (i.e. ".."
-        * or "//"), we stat() the path and search for the corresponding
-        * (major,minor) device pair.
-        */
-       if (stat64(path, &statbuf) != 0) {
-               (void) fprintf(stderr, gettext("cannot %s '%s': %s\n"),
-                   cmdname, path, strerror(errno));
-               return (1);
-       }
-       path_inode = statbuf.st_ino;
 
        /*
         * Search for the given (major,minor) pair in the mount table.
@@ -6990,12 +6978,7 @@ unshare_unmount_path(int op, char *path, int flags, boolean_t is_manual)
        if (freopen(MNTTAB, "r", mnttab_file) == NULL)
                return (ENOENT);
 
-       while ((ret = getextmntent(mnttab_file, &entry, 0)) == 0) {
-               if (entry.mnt_major == major(statbuf.st_dev) &&
-                   entry.mnt_minor == minor(statbuf.st_dev))
-                       break;
-       }
-       if (ret != 0) {
+       if (getextmntent(path, &entry, &statbuf) != 0) {
                if (op == OP_SHARE) {
                        (void) fprintf(stderr, gettext("cannot %s '%s': not "
                            "currently mounted\n"), cmdname, path);
@@ -7008,6 +6991,7 @@ unshare_unmount_path(int op, char *path, int flags, boolean_t is_manual)
                            strerror(errno));
                return (ret != 0);
        }
+       path_inode = statbuf.st_ino;
 
        if (strcmp(entry.mnt_fstype, MNTTYPE_ZFS) != 0) {
                (void) fprintf(stderr, gettext("cannot %s '%s': not a ZFS "
index 6e3e706ec0573bb9583afd124fc884e5ec5548b3..ac4b6aadb655cd6cba00e1db13757ec7d111328b 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 sbin_PROGRAMS = zhack
 
 zhack_SOURCES = \
index ab7f4de123013f7f4bf3d77f7ea71fd2ba1f2044..71b48255e66bee127d28c12e5c58bc6e087c8d89 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 sbin_PROGRAMS = zinject
 
 zinject_SOURCES = \
index d4795d07110fd00efc55389df5c7c4aa2a4e8a3d..8542d37c50bd950de23407a1864c4e468a4bf325 100644 (file)
@@ -85,8 +85,6 @@ parse_pathname(const char *inpath, char *dataset, char *relpath,
     struct stat64 *statbuf)
 {
        struct extmnttab mp;
-       FILE *fp;
-       int match;
        const char *rel;
        char fullpath[MAXPATHLEN];
 
@@ -99,35 +97,7 @@ parse_pathname(const char *inpath, char *dataset, char *relpath,
                return (-1);
        }
 
-       if (strlen(fullpath) >= MAXPATHLEN) {
-               (void) fprintf(stderr, "invalid object; pathname too long\n");
-               return (-1);
-       }
-
-       if (stat64(fullpath, statbuf) != 0) {
-               (void) fprintf(stderr, "cannot open '%s': %s\n",
-                   fullpath, strerror(errno));
-               return (-1);
-       }
-
-#ifdef HAVE_SETMNTENT
-       if ((fp = setmntent(MNTTAB, "r")) == NULL) {
-#else
-       if ((fp = fopen(MNTTAB, "r")) == NULL) {
-#endif
-               (void) fprintf(stderr, "cannot open %s\n", MNTTAB);
-               return (-1);
-       }
-
-       match = 0;
-       while (getextmntent(fp, &mp, sizeof (mp)) == 0) {
-               if (makedev(mp.mnt_major, mp.mnt_minor) == statbuf->st_dev) {
-                       match = 1;
-                       break;
-               }
-       }
-
-       if (!match) {
+       if (getextmntent(fullpath, &mp, statbuf) != 0) {
                (void) fprintf(stderr, "cannot find mountpoint for '%s'\n",
                    fullpath);
                return (-1);
index 42b19ef23592d5d18f350a22ce3c257bfab5e6c1..b9e221c1f7cc4bde0391a5cbe7ad622fc3f0635f 100644 (file)
@@ -1,9 +1,6 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include \
-       -I.
+DEFAULT_INCLUDES += -I.
 
 sbin_PROGRAMS = zpool
 
index 1aaad974e83cdba8e781c25c75590563f2883e57..d087c4c14dac7a2bb8a5940751b9552f1ac34945 100644 (file)
@@ -64,7 +64,6 @@
 
 #include <assert.h>
 #include <ctype.h>
-#include <devid.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <libintl.h>
index af48c6a710b1728ff98d6e4d5aee8ffc53c4e1a2..bb49211dc8e90a034ecaf19dea260031a90ebed0 100644 (file)
@@ -64,7 +64,6 @@
 
 #include <assert.h>
 #include <ctype.h>
-#include <devid.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <libintl.h>
index f80b5018e04ee67d80c2261ceab74adf15b9229b..1f5cd4d9ff814aa609f440cd864825fa082f54a2 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 sbin_PROGRAMS = zstreamdump
 
 zstreamdump_SOURCES = \
index 55af416805949c772152866979ebd1de8932afb0..db9a104c0c7c09021f250ebbe471c3821b871a2b 100644 (file)
@@ -9,10 +9,6 @@ AM_CFLAGS += $(FRAME_LARGER_THAN)
 # Unconditionally enable ASSERTs
 AM_CPPFLAGS += -DDEBUG -UNDEBUG
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 sbin_PROGRAMS = ztest
 
 ztest_SOURCES = \
index d131c6386fc2f0e83a097a449a82afe4cf2f2ff4..a584875081ebb38e10548f6de0fd12803b6f9c10 100644 (file)
@@ -4,10 +4,6 @@ include $(top_srcdir)/config/Rules.am
 # removed once https://github.com/zfsonlinux/zfs/issues/569 is resolved.
 AM_CFLAGS += -fno-stack-protector
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 udev_PROGRAMS = zvol_id
 
 zvol_id_SOURCES = \
index 1e569d3419b1d91bd220aa360a8f41d21798c2c6..83fbf4ca052087dfb254f0dcd9a83acf9230cd16 100644 (file)
@@ -3,7 +3,16 @@
 # should include these rules and override or extend them as needed.
 #
 
-DEFAULT_INCLUDES = -include ${top_builddir}/zfs_config.h
+DEFAULT_INCLUDES = \
+       -include ${top_builddir}/zfs_config.h \
+       -I$(top_srcdir)/include \
+       -I$(top_srcdir)/module/icp/include \
+       -I$(top_srcdir)/lib/libspl/include
+
+if BUILD_LINUX
+DEFAULT_INCLUDES += \
+       -I$(top_srcdir)/lib/libspl/include/os/linux
+endif
 
 AM_LIBTOOLFLAGS = --silent
 
index 444f86a6b14f41f114652e4842c7549d4d7e64fa..8d75b2ec8eaed11b4254d90c7910853472edcb0b 100644 (file)
@@ -86,6 +86,9 @@ AC_CONFIG_FILES([
        lib/libspl/include/Makefile
        lib/libspl/include/ia32/Makefile
        lib/libspl/include/ia32/sys/Makefile
+       lib/libspl/include/os/Makefile
+       lib/libspl/include/os/linux/Makefile
+       lib/libspl/include/os/linux/sys/Makefile
        lib/libspl/include/rpc/Makefile
        lib/libspl/include/sys/Makefile
        lib/libspl/include/sys/dktp/Makefile
index 82b30bd80fa0284d81475ab74401d2238fc8af2e..618cef1e14f48ce60727cf3af53c8211e773d162 100644 (file)
@@ -5,10 +5,6 @@ VPATH = $(top_srcdir)/module/avl/
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libavl.la
 
 USER_C =
index 9f69e46014571da9b1c5ee1170cfabaeb28cfaad..73c817192a207f6a1ae428346f0fde902a82f4a4 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libefi.la
 
 USER_C = \
index e9f22cd707382eacff1cc859c6e454726e5bd95f..8b6c4177144df2a17e602f9a78591617a4f7d29c 100644 (file)
@@ -7,11 +7,6 @@ VPATH = \
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/module/icp/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libicp.la
 
 if TARGET_ASM_X86_64
index 6d59d7bfc6e2590d5934debf02be3da7402e751a..6626b6d05483eb555053491a6ae4fe899b68f299 100644 (file)
@@ -8,10 +8,6 @@ VPATH = \
 # and required CFLAGS for libtirpc
 AM_CFLAGS += $(FRAME_LARGER_THAN) $(LIBTIRPC_CFLAGS)
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 lib_LTLIBRARIES = libnvpair.la
 
 USER_C = \
index 462e333ffcd647ea3ad61f4d59450994b0276ad3..b082d992be2c68e3010a206063537542662cdebf 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libshare.la
 
 USER_C = \
index cd74676dd2524e91c6077226b312c81a10c6cf28..313760175c5a4cea508053008b4939958b39ebf9 100644 (file)
@@ -7,9 +7,6 @@ VPATH = \
 SUBDIRS = include $(TARGET_ASM_DIR)
 DIST_SUBDIRS = include asm-generic asm-i386 asm-x86_64
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/lib/libspl/include
-
 AM_CFLAGS += $(LIBTIRPC_CFLAGS)
 
 AM_CCASFLAGS = \
@@ -18,9 +15,6 @@ AM_CCASFLAGS = \
 noinst_LTLIBRARIES = libspl.la
 
 USER_C = \
-       getexecname.c \
-       gethostid.c \
-       getmntany.c \
        list.c \
        mkdirp.c \
        page.c \
@@ -31,6 +25,13 @@ USER_C = \
        include/sys/list.h \
        include/sys/list_impl.h
 
+if BUILD_LINUX
+USER_C += \
+       os/linux/getexecname.c \
+       os/linux/gethostid.c \
+       os/linux/getmntany.c
+endif
+
 USER_ASM = atomic.S
 
 nodist_libspl_la_SOURCES = \
index 17fe501fa1836baddc4b063effd62030dfbf331a..39682316073db50ee2d8868dd85bb73aa93eb0d1 100644 (file)
@@ -1,8 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-        -I$(top_srcdir)/lib/libspl/include
-
 atomic_SOURCE = atomic.c
 atomic_ASM = atomic.S
 
index 842a8fbb39d9d5f7354c87286329ae5c60679576..2fd0c15ff3993ba3a8062bebc8c08eca8b920ca6 100644 (file)
@@ -1,10 +1,9 @@
-SUBDIRS = ia32 rpc sys util
+SUBDIRS = ia32 rpc sys util os
 
 libspldir = $(includedir)/libspl
 libspl_HEADERS = \
        $(top_srcdir)/lib/libspl/include/assert.h \
        $(top_srcdir)/lib/libspl/include/atomic.h \
-       $(top_srcdir)/lib/libspl/include/devid.h \
        $(top_srcdir)/lib/libspl/include/libdevinfo.h \
        $(top_srcdir)/lib/libspl/include/libgen.h \
        $(top_srcdir)/lib/libspl/include/libshare.h \
diff --git a/lib/libspl/include/devid.h b/lib/libspl/include/devid.h
deleted file mode 100644 (file)
index 8e48328..0000000
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * CDDL HEADER START
- *
- * The contents of this file are subject to the terms of the
- * Common Development and Distribution License, Version 1.0 only
- * (the "License").  You may not use this file except in compliance
- * with the License.
- *
- * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
- * or http://www.opensolaris.org/os/licensing.
- * See the License for the specific language governing permissions
- * and limitations under the License.
- *
- * When distributing Covered Code, include this CDDL HEADER in each
- * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
- * If applicable, add the following below this CDDL HEADER, with the
- * fields enclosed by brackets "[]" replaced with your own identifying
- * information: Portions Copyright [yyyy] [name of copyright owner]
- *
- * CDDL HEADER END
- */
-/*
- * Copyright 2006 Sun Microsystems, Inc.  All rights reserved.
- * Use is subject to license terms.
- */
-
-#ifndef _LIBSPL_DEVID_H
-#define        _LIBSPL_DEVID_H
-
-#include <sys/types.h>
-
-#endif
diff --git a/lib/libspl/include/os/Makefile.am b/lib/libspl/include/os/Makefile.am
new file mode 100644 (file)
index 0000000..09c0bee
--- /dev/null
@@ -0,0 +1,3 @@
+if BUILD_LINUX
+SUBDIRS = linux
+endif
diff --git a/lib/libspl/include/os/linux/Makefile.am b/lib/libspl/include/os/linux/Makefile.am
new file mode 100644 (file)
index 0000000..081839c
--- /dev/null
@@ -0,0 +1 @@
+SUBDIRS = sys
diff --git a/lib/libspl/include/os/linux/sys/Makefile.am b/lib/libspl/include/os/linux/sys/Makefile.am
new file mode 100644 (file)
index 0000000..c11732c
--- /dev/null
@@ -0,0 +1,10 @@
+libspldir = $(includedir)/libspl/sys
+libspl_HEADERS = \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/byteorder.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/file.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/mnttab.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/mount.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/param.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/stat.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/sysmacros.h \
+       $(top_srcdir)/lib/libspl/include/os/linux/sys/uio.h
similarity index 94%
rename from lib/libspl/include/sys/mnttab.h
rename to lib/libspl/include/os/linux/sys/mnttab.h
index 026a8fa7beeeaa1cc8d87c2c2a9da5ff7c4f48e2..7b30bf1d547853058954faecc810878e70cb8531 100644 (file)
@@ -67,10 +67,13 @@ struct extmnttab {
        uint_t mnt_minor;
 };
 
+struct stat64;
+struct statfs;
+
 extern int getmntany(FILE *fp, struct mnttab *mp, struct mnttab *mpref);
 extern int _sol_getmntent(FILE *fp, struct mnttab *mp);
-extern int getextmntent(FILE *fp, struct extmnttab *mp, int len);
-
+extern int getextmntent(const char *path, struct extmnttab *mp,
+    struct stat64 *statbuf);
 static inline char *_sol_hasmntopt(struct mnttab *mnt, char *opt)
 {
        struct mntent mnt_new;
similarity index 95%
rename from lib/libspl/include/sys/uio.h
rename to lib/libspl/include/os/linux/sys/uio.h
index 91ee3b3fd00d9efd7fbd16f0ecb6198ebdbc4e65..0b85af66dcc12601db22953f5f9f3219c4489e4b 100644 (file)
 #ifndef        _LIBSPL_SYS_UIO_H
 #define        _LIBSPL_SYS_UIO_H
 
+#include <sys/types.h>
 #include_next <sys/uio.h>
 
+#include <stdint.h>
 typedef struct iovec iovec_t;
 
 typedef enum uio_rw {
@@ -58,11 +60,11 @@ typedef enum uio_seg {
 typedef struct uio {
        struct iovec    *uio_iov;       /* pointer to array of iovecs */
        int             uio_iovcnt;     /* number of iovecs */
-       offset_t        uio_loffset;    /* file offset */
+       loff_t          uio_loffset;    /* file offset */
        uio_seg_t       uio_segflg;     /* address space (kernel or user) */
        uint16_t        uio_fmode;      /* file mode flags */
        uint16_t        uio_extflg;     /* extended flags */
-       offset_t        uio_limit;      /* u-limit (maximum byte offset) */
+       loff_t          uio_limit;      /* u-limit (maximum byte offset) */
        ssize_t         uio_resid;      /* residual count */
 } uio_t;
 
index 60ddb7881a1e9351b40b02535f27e758b289133d..54aece1299f6dfa4cba40fc9811365217dc7286a 100644 (file)
@@ -5,7 +5,6 @@ libspl_HEADERS = \
        $(top_srcdir)/lib/libspl/include/sys/acl.h \
        $(top_srcdir)/lib/libspl/include/sys/acl_impl.h \
        $(top_srcdir)/lib/libspl/include/sys/bitmap.h \
-       $(top_srcdir)/lib/libspl/include/sys/byteorder.h \
        $(top_srcdir)/lib/libspl/include/sys/callb.h \
        $(top_srcdir)/lib/libspl/include/sys/cmn_err.h \
        $(top_srcdir)/lib/libspl/include/sys/cred.h \
@@ -14,7 +13,6 @@ libspl_HEADERS = \
        $(top_srcdir)/lib/libspl/include/sys/dklabel.h \
        $(top_srcdir)/lib/libspl/include/sys/errno.h \
        $(top_srcdir)/lib/libspl/include/sys/feature_tests.h \
-       $(top_srcdir)/lib/libspl/include/sys/file.h \
        $(top_srcdir)/lib/libspl/include/sys/int_limits.h \
        $(top_srcdir)/lib/libspl/include/sys/int_types.h \
        $(top_srcdir)/lib/libspl/include/sys/inttypes.h \
@@ -25,29 +23,22 @@ libspl_HEADERS = \
        $(top_srcdir)/lib/libspl/include/sys/list_impl.h \
        $(top_srcdir)/lib/libspl/include/sys/mhd.h \
        $(top_srcdir)/lib/libspl/include/sys/mkdev.h \
-       $(top_srcdir)/lib/libspl/include/sys/mnttab.h \
-       $(top_srcdir)/lib/libspl/include/sys/mount.h \
-       $(top_srcdir)/lib/libspl/include/sys/param.h \
        $(top_srcdir)/lib/libspl/include/sys/policy.h \
        $(top_srcdir)/lib/libspl/include/sys/poll.h \
        $(top_srcdir)/lib/libspl/include/sys/priv.h \
        $(top_srcdir)/lib/libspl/include/sys/processor.h \
-       $(top_srcdir)/lib/libspl/include/sys/signal.h \
        $(top_srcdir)/lib/libspl/include/sys/simd.h \
        $(top_srcdir)/lib/libspl/include/sys/stack.h \
-       $(top_srcdir)/lib/libspl/include/sys/stat.h \
        $(top_srcdir)/lib/libspl/include/sys/stdtypes.h \
        $(top_srcdir)/lib/libspl/include/sys/strings.h \
        $(top_srcdir)/lib/libspl/include/sys/stropts.h \
        $(top_srcdir)/lib/libspl/include/sys/sunddi.h \
-       $(top_srcdir)/lib/libspl/include/sys/sysmacros.h \
        $(top_srcdir)/lib/libspl/include/sys/systeminfo.h \
        $(top_srcdir)/lib/libspl/include/sys/time.h \
        $(top_srcdir)/lib/libspl/include/sys/trace_defs.h \
        $(top_srcdir)/lib/libspl/include/sys/types32.h \
        $(top_srcdir)/lib/libspl/include/sys/types.h \
        $(top_srcdir)/lib/libspl/include/sys/tzfile.h \
-       $(top_srcdir)/lib/libspl/include/sys/uio.h \
        $(top_srcdir)/lib/libspl/include/sys/va_list.h \
        $(top_srcdir)/lib/libspl/include/sys/varargs.h \
        $(top_srcdir)/lib/libspl/include/sys/vnode.h \
similarity index 62%
rename from lib/libspl/getmntany.c
rename to lib/libspl/os/linux/getmntany.c
index 43e523e4a58920e154999c5b6a467f945336dd75..f42fcc047893721f518dbc2f7e38bf98ee1d135b 100644 (file)
@@ -31,6 +31,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <mntent.h>
+#include <sys/errno.h>
 #include <sys/mnttab.h>
 
 #include <sys/types.h>
@@ -81,8 +82,8 @@ _sol_getmntent(FILE *fp, struct mnttab *mgetp)
        return (MNT_TOOLONG);
 }
 
-int
-getextmntent(FILE *fp, struct extmnttab *mp, int len)
+static int
+getextmntent_impl(FILE *fp, struct extmnttab *mp, int len)
 {
        int ret;
        struct stat64 st;
@@ -100,3 +101,65 @@ getextmntent(FILE *fp, struct extmnttab *mp, int len)
 
        return (ret);
 }
+
+int
+getextmntent(const char *path, struct extmnttab *entry, struct stat64 *statbuf)
+{
+       struct stat64 st;
+       FILE *fp;
+       int match;
+
+       if (strlen(path) >= MAXPATHLEN) {
+               (void) fprintf(stderr, "invalid object; pathname too long\n");
+               return (-1);
+       }
+
+       /*
+        * Search for the path in /proc/self/mounts. Rather than looking for the
+        * specific path, which can be fooled by non-standard paths (i.e. ".."
+        * or "//"), we stat() the path and search for the corresponding
+        * (major,minor) device pair.
+        */
+       if (stat64(path, statbuf) != 0) {
+               (void) fprintf(stderr, "cannot open '%s': %s\n",
+                   path, strerror(errno));
+               return (-1);
+       }
+
+
+#ifdef HAVE_SETMNTENT
+       if ((fp = setmntent(MNTTAB, "r")) == NULL) {
+#else
+       if ((fp = fopen(MNTTAB, "r")) == NULL) {
+#endif
+               (void) fprintf(stderr, "cannot open %s\n", MNTTAB);
+               return (-1);
+       }
+
+       /*
+        * Search for the given (major,minor) pair in the mount table.
+        */
+
+       match = 0;
+       while (getextmntent_impl(fp, entry, sizeof (*entry)) == 0) {
+               if (makedev(entry->mnt_major, entry->mnt_minor) ==
+                   statbuf->st_dev) {
+                       match = 1;
+                       break;
+               }
+       }
+
+       if (!match) {
+               (void) fprintf(stderr, "cannot find mountpoint for '%s'\n",
+                   path);
+               return (-1);
+       }
+
+       if (stat64(entry->mnt_mountp, &st) != 0) {
+               entry->mnt_major = 0;
+               entry->mnt_minor = 0;
+               return (-1);
+       }
+
+       return (0);
+}
index 586eec2ec9e14eb24f3585ad04d379ede459d25f..7734699476fdf08d9f92c540114ad1c232c43fc5 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libtpool.la
 
 USER_C = \
index 0a4734c037bd2dedff8d729f21a8e342f8b0b4b7..ea9439d1328e3781aed99e9c8d8427d02e7b347f 100644 (file)
@@ -5,10 +5,6 @@ VPATH = $(top_srcdir)/module/unicode
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libunicode.la
 
 USER_C =
index 09eef792a23581ed6370e56e29ad9ab5dab0fed5..c61b66fce32f232ca8d40349fdb6e1b15ce4889c 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 lib_LTLIBRARIES = libuutil.la
 
 USER_C = \
index 421970413dafd43df4c4476905f99c712863a4c2..3d14a77c1a8b78510881896f2b664f7bbef20fd2 100644 (file)
@@ -11,11 +11,6 @@ AM_CFLAGS += $(NO_UNUSED_BUT_SET_VARIABLE)
 libzfs_pcdir = $(datarootdir)/pkgconfig
 libzfs_pc_DATA = libzfs.pc libzfs_core.pc
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/module/icp/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 lib_LTLIBRARIES = libzfs.la
 
 USER_C = \
index 3d7a0bf12a05582933d624ac9e3c432f0f2cc99b..747977403d3c5764b499e494a228e7bd3599578c 100644 (file)
@@ -26,7 +26,6 @@
  * Copyright (c) 2016, Intel Corporation.
  */
 
-#include <devid.h>
 #include <errno.h>
 #include <libintl.h>
 #include <libgen.h>
index 00f69b26d3e8d72cb7eca0de1bad6a41053fb8e0..2641b11528a224f2c21e2f42462ce798ddfd08ce 100644 (file)
@@ -31,7 +31,6 @@
  */
 
 #include <errno.h>
-#include <devid.h>
 #include <libintl.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -3884,86 +3883,6 @@ zpool_sync_one(zpool_handle_t *zhp, void *data)
        return (0);
 }
 
-#if defined(__sun__) || defined(__sun)
-/*
- * Convert from a devid string to a path.
- */
-static char *
-devid_to_path(char *devid_str)
-{
-       ddi_devid_t devid;
-       char *minor;
-       char *path;
-       devid_nmlist_t *list = NULL;
-       int ret;
-
-       if (devid_str_decode(devid_str, &devid, &minor) != 0)
-               return (NULL);
-
-       ret = devid_deviceid_to_nmlist("/dev", devid, minor, &list);
-
-       devid_str_free(minor);
-       devid_free(devid);
-
-       if (ret != 0)
-               return (NULL);
-
-       /*
-        * In a case the strdup() fails, we will just return NULL below.
-        */
-       path = strdup(list[0].devname);
-
-       devid_free_nmlist(list);
-
-       return (path);
-}
-
-/*
- * Convert from a path to a devid string.
- */
-static char *
-path_to_devid(const char *path)
-{
-       int fd;
-       ddi_devid_t devid;
-       char *minor, *ret;
-
-       if ((fd = open(path, O_RDONLY)) < 0)
-               return (NULL);
-
-       minor = NULL;
-       ret = NULL;
-       if (devid_get(fd, &devid) == 0) {
-               if (devid_get_minor_name(fd, &minor) == 0)
-                       ret = devid_str_encode(devid, minor);
-               if (minor != NULL)
-                       devid_str_free(minor);
-               devid_free(devid);
-       }
-       (void) close(fd);
-
-       return (ret);
-}
-
-/*
- * Issue the necessary ioctl() to update the stored path value for the vdev.  We
- * ignore any failure here, since a common case is for an unprivileged user to
- * type 'zpool status', and we'll display the correct information anyway.
- */
-static void
-set_path(zpool_handle_t *zhp, nvlist_t *nv, const char *path)
-{
-       zfs_cmd_t zc = {"\0"};
-
-       (void) strncpy(zc.zc_name, zhp->zpool_name, sizeof (zc.zc_name));
-       (void) strncpy(zc.zc_value, path, sizeof (zc.zc_value));
-       verify(nvlist_lookup_uint64(nv, ZPOOL_CONFIG_GUID,
-           &zc.zc_guid) == 0);
-
-       (void) ioctl(zhp->zpool_hdl->libzfs_fd, ZFS_IOC_VDEV_SETPATH, &zc);
-}
-#endif /* sun */
-
 #define        PATH_BUF_LEN    64
 
 /*
@@ -4019,54 +3938,6 @@ zpool_vdev_name(libzfs_handle_t *hdl, zpool_handle_t *zhp, nvlist_t *nv,
                (void) snprintf(buf, sizeof (buf), "%llu", (u_longlong_t)value);
                path = buf;
        } else if (nvlist_lookup_string(nv, ZPOOL_CONFIG_PATH, &path) == 0) {
-#if defined(__sun__) || defined(__sun)
-               /*
-                * Live VDEV path updates to a kernel VDEV during a
-                * zpool_vdev_name lookup are not supported on Linux.
-                */
-               char *devid;
-               vdev_stat_t *vs;
-               uint_t vsc;
-
-               /*
-                * If the device is dead (faulted, offline, etc) then don't
-                * bother opening it.  Otherwise we may be forcing the user to
-                * open a misbehaving device, which can have undesirable
-                * effects.
-                */
-               if ((nvlist_lookup_uint64_array(nv, ZPOOL_CONFIG_VDEV_STATS,
-                   (uint64_t **)&vs, &vsc) != 0 ||
-                   vs->vs_state >= VDEV_STATE_DEGRADED) &&
-                   zhp != NULL &&
-                   nvlist_lookup_string(nv, ZPOOL_CONFIG_DEVID, &devid) == 0) {
-                       /*
-                        * Determine if the current path is correct.
-                        */
-                       char *newdevid = path_to_devid(path);
-
-                       if (newdevid == NULL ||
-                           strcmp(devid, newdevid) != 0) {
-                               char *newpath;
-
-                               if ((newpath = devid_to_path(devid)) != NULL) {
-                                       /*
-                                        * Update the path appropriately.
-                                        */
-                                       set_path(zhp, nv, newpath);
-                                       if (nvlist_add_string(nv,
-                                           ZPOOL_CONFIG_PATH, newpath) == 0)
-                                               verify(nvlist_lookup_string(nv,
-                                                   ZPOOL_CONFIG_PATH,
-                                                   &path) == 0);
-                                       free(newpath);
-                               }
-                       }
-
-                       if (newdevid)
-                               devid_str_free(newdevid);
-               }
-#endif /* sun */
-
                if (name_flags & VDEV_NAME_FOLLOW_LINKS) {
                        char *rp = realpath(path, NULL);
                        if (rp) {
index de4d8bff9ae1243ca3fac0d375ea199e1b394be6..04100071d051253a3c014fd88258ad2a86d545e2 100644 (file)
@@ -1095,7 +1095,6 @@ zfs_path_to_zhandle(libzfs_handle_t *hdl, char *path, zfs_type_t argtype)
 {
        struct stat64 statbuf;
        struct extmnttab entry;
-       int ret;
 
        if (path[0] != '/' && strncmp(path, "./", strlen("./")) != 0) {
                /*
@@ -1104,24 +1103,12 @@ zfs_path_to_zhandle(libzfs_handle_t *hdl, char *path, zfs_type_t argtype)
                return (zfs_open(hdl, path, argtype));
        }
 
-       if (stat64(path, &statbuf) != 0) {
-               (void) fprintf(stderr, "%s: %s\n", path, strerror(errno));
-               return (NULL);
-       }
-
        /* Reopen MNTTAB to prevent reading stale data from open file */
        if (freopen(MNTTAB, "r", hdl->libzfs_mnttab) == NULL)
                return (NULL);
 
-       while ((ret = getextmntent(hdl->libzfs_mnttab, &entry, 0)) == 0) {
-               if (makedevice(entry.mnt_major, entry.mnt_minor) ==
-                   statbuf.st_dev) {
-                       break;
-               }
-       }
-       if (ret != 0) {
+       if (getextmntent(path, &entry, &statbuf) != 0)
                return (NULL);
-       }
 
        if (strcmp(entry.mnt_fstype, MNTTYPE_ZFS) != 0) {
                (void) fprintf(stderr, gettext("'%s': not a ZFS filesystem\n"),
index 421b8b4bfbc6ceb8f9609ead9454b172397a746b..bc3d309f82e07e6c425860d8594aed60772f6b51 100644 (file)
@@ -1,9 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 lib_LTLIBRARIES = libzfs_core.la
 
 USER_C = \
index 1b2405a533ac8a3c5dfa0aed85d117f9b793cbdb..97f9abcf43d5a50bef34b7a2905a7b1d287d9409 100644 (file)
@@ -15,10 +15,6 @@ AM_CFLAGS += $(FRAME_LARGER_THAN)
 
 AM_CFLAGS += -DLIB_ZPOOL_BUILD
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 lib_LTLIBRARIES = libzpool.la
 
 USER_C = \
index 40a98afba4037b833ad7c781a4f2c7f3d72165e1..965740eac0d6a23aa669b3acd96e04af564d4032 100644 (file)
@@ -504,60 +504,16 @@ vn_open(char *path, int x1, int flags, int mode, vnode_t **vpp, int x2, int x3)
        int dump_fd = -1;
        vnode_t *vp;
        int old_umask = 0;
-       char *realpath;
        struct stat64 st;
        int err;
 
-       realpath = umem_alloc(MAXPATHLEN, UMEM_NOFAIL);
-
-       /*
-        * If we're accessing a real disk from userland, we need to use
-        * the character interface to avoid caching.  This is particularly
-        * important if we're trying to look at a real in-kernel storage
-        * pool from userland, e.g. via zdb, because otherwise we won't
-        * see the changes occurring under the segmap cache.
-        * On the other hand, the stupid character device returns zero
-        * for its size.  So -- gag -- we open the block device to get
-        * its size, and remember it for subsequent VOP_GETATTR().
-        */
-#if defined(__sun__) || defined(__sun)
-       if (strncmp(path, "/dev/", 5) == 0) {
-#else
-       if (0) {
-#endif
-               char *dsk;
-               fd = open64(path, O_RDONLY);
-               if (fd == -1) {
-                       err = errno;
-                       free(realpath);
-                       return (err);
-               }
-               if (fstat64(fd, &st) == -1) {
-                       err = errno;
-                       close(fd);
-                       free(realpath);
-                       return (err);
-               }
-               close(fd);
-               (void) sprintf(realpath, "%s", path);
-               dsk = strstr(path, "/dsk/");
-               if (dsk != NULL)
-                       (void) sprintf(realpath + (dsk - path) + 1, "r%s",
-                           dsk + 1);
-       } else {
-               (void) sprintf(realpath, "%s", path);
-               if (!(flags & FCREAT) && stat64(realpath, &st) == -1) {
-                       err = errno;
-                       free(realpath);
-                       return (err);
-               }
+       if (!(flags & FCREAT) && stat64(path, &st) == -1) {
+               err = errno;
+               return (err);
        }
 
-       if (!(flags & FCREAT) && S_ISBLK(st.st_mode)) {
-#ifdef __linux__
+       if (!(flags & FCREAT) && S_ISBLK(st.st_mode))
                flags |= O_DIRECT;
-#endif
-       }
 
        if (flags & FCREAT)
                old_umask = umask(0);
@@ -566,10 +522,9 @@ vn_open(char *path, int x1, int flags, int mode, vnode_t **vpp, int x2, int x3)
         * The construct 'flags - FREAD' conveniently maps combinations of
         * FREAD and FWRITE to the corresponding O_RDONLY, O_WRONLY, and O_RDWR.
         */
-       fd = open64(realpath, flags - FREAD, mode);
+       fd = open64(path, flags - FREAD, mode);
        if (fd == -1) {
                err = errno;
-               free(realpath);
                return (err);
        }
 
@@ -579,12 +534,11 @@ vn_open(char *path, int x1, int flags, int mode, vnode_t **vpp, int x2, int x3)
        if (vn_dumpdir != NULL) {
                char *dumppath = umem_zalloc(MAXPATHLEN, UMEM_NOFAIL);
                (void) snprintf(dumppath, MAXPATHLEN,
-                   "%s/%s", vn_dumpdir, basename(realpath));
+                   "%s/%s", vn_dumpdir, basename(path));
                dump_fd = open64(dumppath, O_CREAT | O_WRONLY, 0666);
                umem_free(dumppath, MAXPATHLEN);
                if (dump_fd == -1) {
                        err = errno;
-                       free(realpath);
                        close(fd);
                        return (err);
                }
@@ -592,8 +546,6 @@ vn_open(char *path, int x1, int flags, int mode, vnode_t **vpp, int x2, int x3)
                dump_fd = -1;
        }
 
-       free(realpath);
-
        if (fstat64_blk(fd, &st) == -1) {
                err = errno;
                close(fd);
index 720b843ab97d30b7b6c03d8107e566f92801b3d3..62b0114ed033e9bb8b90dae64918201d774d0e1c 100644 (file)
@@ -3,10 +3,6 @@ include $(top_srcdir)/config/Rules.am
 # Suppress unused but set variable warnings often due to ASSERTs
 AM_CFLAGS += $(NO_UNUSED_BUT_SET_VARIABLE)
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 noinst_LTLIBRARIES = libzutil.la
 
 USER_C = \
index 28733cc747cc982d3553d6e2cc6f8969252508c0..bb7db259cb185d83166d8c1e41d5b838b79966f5 100644 (file)
@@ -47,7 +47,6 @@
  */
 
 #include <ctype.h>
-#include <devid.h>
 #include <dirent.h>
 #include <errno.h>
 #include <libintl.h>
index 81fc5de397940ccb40c363519a6e643e7aaaa28a..ec393be7f8fb4a4713bbe87235e6abfbcbe639d4 100644 (file)
 #include <time.h>
 #include <stdint.h>
 
-typedef unsigned char  uchar_t;
-typedef long long      longlong_t;
-typedef longlong_t     offset_t;
-
 static unsigned char bigbuffer[BIGBUFFERSIZE];
 
 /*
index d1eceaf56825e455f7967b5389ab8e690d3fd094..00e1019cc8e4ccd1a139d8a6c1945e9667bd43fc 100644 (file)
 #include <signal.h>
 #include <stdio.h>
 #include <string.h>
-#include <sys/types.h>
+#include <sys/stdtypes.h>
 #include <unistd.h>
 
-typedef long long      offset_t;
-#define        MAXOFFSET_T     LLONG_MAX
-
 /*
  * --------------------------------------------------------------
  *
index b62a6bb0f564f2a9c4f057c828a4793ee02b36fa..32cc46561ff66dab4fea9564e477b5131b292b6d 100644 (file)
@@ -2,10 +2,6 @@ include $(top_srcdir)/config/Rules.am
 
 pkgexecdir = $(datadir)/@PACKAGE@/zfs-tests/bin
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 pkgexec_PROGRAMS = libzfs_input_check
 
 libzfs_input_check_SOURCES = libzfs_input_check.c
index 9634904f0d56890cfa05239f7c124c205cd1b6dc..c26822bb5778feb568d31461818b3cc80fe115fa 100644 (file)
@@ -30,8 +30,6 @@
 #include <errno.h>
 #include <string.h>
 
-typedef enum boolean { B_FALSE, B_TRUE } boolean_t;
-
 static void
 usage(char *progname)
 {
index 7ebf7bbcf83a33f4ea6723e92c3a28f9cd6fbfec..888af6db6a60078e8c072c1c7b49a64058c33c55 100644 (file)
 #include <libintl.h>
 #include <errno.h>
 
-#define        MIN(a, b)       ((a) < (b) ? (a) : (b))
-
-#define        BLOCK_SIZE      512             /* bytes */
+#define        BLOCKSIZE       512             /* bytes */
 #define        KILOBYTE        1024
 #define        MEGABYTE        (KILOBYTE * KILOBYTE)
 #define        GIGABYTE        (KILOBYTE * MEGABYTE)
 
 #define        FILE_MODE       (S_ISVTX + S_IRUSR + S_IWUSR)
 
-typedef long long      offset_t;
-
 static void usage(void);
 
 int
@@ -95,7 +91,7 @@ main(int argc, char **argv)
                        break;
                case 'b':
                case 'B':
-                       mult = BLOCK_SIZE;
+                       mult = BLOCKSIZE;
                        break;
                case 'm':
                case 'M':
index f509a97e38942f1f728708186e3f6782f016e2cf..7d60c24821b54b188ca3efae493c81cdac362a9c 100644 (file)
@@ -2,10 +2,6 @@ include $(top_srcdir)/config/Rules.am
 
 pkgexecdir = $(datadir)/@PACKAGE@/zfs-tests/bin
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 pkgexec_PROGRAMS = nvlist_to_lua
 
 nvlist_to_lua_SOURCES = nvlist_to_lua.c
index a2a924e5d89aaf1cd71d9330a14f362ee5038afe..a88756091e3d7894005ec29b7222a28b60048afa 100644 (file)
@@ -38,9 +38,7 @@
 #include <stdio.h>
 #include <sys/note.h>
 #include <sys/time.h>
-
-typedef enum boolean { B_FALSE, B_TRUE } boolean_t;
-typedef        unsigned long long      u_longlong_t;
+#include <sys/stdtypes.h>
 
 /*
  * Test messages from:
index afd6f82438b676f0ed30cf9c4f896c28f8a744e7..25a8d2bf3652649693f37ae93d7591a0897bc748 100644 (file)
@@ -39,9 +39,8 @@
 #include <sys/time.h>
 #define        _SHA2_IMPL
 #include <sys/sha2.h>
+#include <sys/stdtypes.h>
 #define NOTE(x)
-typedef enum boolean { B_FALSE, B_TRUE } boolean_t;
-typedef        unsigned long long      u_longlong_t;
 
 
 /*
index 37548f03b37877397790a29d7b81fd1a2e3802f7..55df9075c66bc4396f64105b0543c0eff473db95 100644 (file)
 #include <strings.h>
 #include <stdio.h>
 #include <sys/time.h>
+#include <sys/stdtypes.h>
 #define NOTE(x)
 
-typedef        enum boolean { B_FALSE, B_TRUE } boolean_t;
-typedef        unsigned long long      u_longlong_t;
-
 /*
  * Skein test suite using values from the Skein V1.3 specification found at:
  * http://www.skein-hash.info/sites/default/files/skein1.3.pdf
index b54e353cd963508a707f6c044d900fb06c525a69..c1266214fefd632d5aa1a7aeecb93a57c30cccb4 100644 (file)
@@ -1,7 +1,5 @@
 include $(top_srcdir)/config/Rules.am
 
-AM_CPPFLAGS += -I$(top_srcdir)/include
-AM_CPPFLAGS += -I$(top_srcdir)/lib/libspl/include
 LDADD = $(top_builddir)/lib/libzpool/libzpool.la
 
 AUTOMAKE_OPTIONS = subdir-objects
index ae9be5097a1b0f6e6b55e115a7ddca796f248372..e9a703f4902d1c3686e3696469951f56d5cc71ad 100644 (file)
@@ -9,10 +9,6 @@ dist_pkgdata_SCRIPTS = \
        setup.ksh \
        libzfs_input.ksh
 
-DEFAULT_INCLUDES += \
-       -I$(top_srcdir)/include \
-       -I$(top_srcdir)/lib/libspl/include
-
 many_fds_LDADD = \
        $(top_builddir)/lib/libzfs/libzfs.la