]> granicus.if.org Git - graphviz/commitdiff
graphml2gv: remove 'composite_buffer' from 'userdata_t'
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Thu, 13 Oct 2022 04:36:28 +0000 (21:36 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Fri, 14 Oct 2022 15:36:14 +0000 (08:36 -0700)
1d28d7d2b4d2b2551bd1f432aa175f54a69364a4 seems to have copied this
implementation of `userdata_t` from cmd/tools/gxl2gv.c without noticing the
`composite_buffer` member is never used in graphml2gv.

cmd/tools/graphml2gv.c

index c7e5960be08a5ea0af91b94f7d86a369ffbe17ce..57018e09b170d070350bc74a132fa3b12d5ceb22 100644 (file)
@@ -15,7 +15,6 @@
 
 
 #include    "convert.h"
-#include    <cgraph/agxbuf.h>
 #include    <cgraph/alloc.h>
 #include    <cgraph/exit.h>
 #include    <cgraph/likely.h>
@@ -86,7 +85,6 @@ static void freeString(gv_stack_t *stk) {
 }
 
 typedef struct {
-    agxbuf composite_buffer;
     char* gname;
     gv_stack_t elements;
     int closedElementType;
@@ -144,7 +142,6 @@ static userdata_t *genUserdata(char* dfltname)
 static void freeUserdata(userdata_t * ud)
 {
     dtclose(ud->nameMap);
-    agxbfree(&(ud->composite_buffer));
     freeString(&ud->elements);
     free(ud);
 }